Skip to content

Commit 8a0fdca

Browse files
committed
#554 Tasks that setMain now work with Gradle 6.4+
Followed example at https://github.com/franzbecker/gradle-lombok/pull/77/files
1 parent 4d91444 commit 8a0fdca

File tree

9 files changed

+33
-12
lines changed

9 files changed

+33
-12
lines changed

examples/corb2-project/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ buildscript {
2323
}
2424

2525
plugins {
26-
id "com.marklogic.ml-gradle" version "3.17.0"
26+
id "com.marklogic.ml-gradle" version "4.0.4"
2727
}
2828

2929
repositories {

examples/corb2-project/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-3.5-bin.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.5.1-bin.zip

examples/mlcp-project/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
*/
66

77
plugins {
8-
id "com.marklogic.ml-gradle" version "3.10.0"
8+
id "com.marklogic.ml-gradle" version "4.0.4"
99
}
1010

1111
repositories {

examples/mlcp-project/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-3.5-bin.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.5.1-bin.zip

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
group=com.marklogic
2-
version=4.0.3
2+
version=4.0.4
33
javadocsDir=../gh-pages-marklogic-java/javadocs
44

55
mlAppDeployerDependency=com.marklogic:ml-app-deployer:4.0.2
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
#Tue Mar 22 14:27:38 EDT 2016
1+
#Fri Jul 17 11:35:34 EDT 2020
2+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.5.1-all.zip
23
distributionBase=GRADLE_USER_HOME
34
distributionPath=wrapper/dists
4-
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.2-bin.zip
6+
zipStoreBase=GRADLE_USER_HOME

src/main/groovy/com/marklogic/gradle/task/CorbTask.groovy

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.marklogic.gradle.task
22

3+
import org.gradle.api.Task
34
import org.gradle.api.tasks.JavaExec
45
import org.gradle.api.tasks.TaskAction
56

@@ -88,14 +89,20 @@ XQUERY-MODULE".tokenize(',')
8889
// corb defaults to 1, but 8 seems like a more common default
8990
def threadCount = 8 // THREAD-COUNT
9091

91-
@TaskAction
92+
// Starting in Gradle 6.4, setMain must be called here instead of in a TaskAction method
93+
@Override
94+
Task configure(Closure closure) {
95+
setMain("com.marklogic.developer.corb.Manager")
96+
return super.configure(closure)
97+
}
98+
99+
@TaskAction
92100
@Override
93101
public void exec() {
94102
//By convention, if there is a corb configuration, use it to set the classpath
95103
if (getProject().configurations.findByName('corb')) {
96104
setClasspath(getProject().configurations.corb)
97105
}
98-
setMain("com.marklogic.developer.corb.Manager")
99106

100107
Map options = buildCorbOptions()
101108
//CoRB2 will evaluate System properties for options

src/main/groovy/com/marklogic/gradle/task/MlcpTask.groovy

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package com.marklogic.gradle.task
33
import com.marklogic.client.DatabaseClient
44
import com.marklogic.client.io.FileHandle
55
import com.marklogic.contentpump.bean.MlcpBean
6+
import org.gradle.api.Task
67
import org.gradle.api.logging.Logger
78
import org.gradle.api.logging.Logging
89
import org.gradle.api.tasks.JavaExec
@@ -35,10 +36,16 @@ class MlcpTask extends JavaExec {
3536
return Logging.getLogger(MlcpTask.class)
3637
}
3738

39+
// Starting in Gradle 6.4, setMain must be called here instead of in a TaskAction method
40+
@Override
41+
Task configure(Closure closure) {
42+
setMain("com.marklogic.contentpump.ContentPump")
43+
return super.configure(closure)
44+
}
45+
3846
@TaskAction
3947
@Override
4048
void exec() {
41-
setMain("com.marklogic.contentpump.ContentPump")
4249
AppConfig config = getProject().property("mlAppConfig")
4350

4451
List<String> newArgs = new ArrayList<>()

src/main/groovy/com/marklogic/gradle/task/shell/ShellTask.groovy

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.marklogic.gradle.task.shell
22

33
import org.gradle.api.Project
4+
import org.gradle.api.Task
45
import org.gradle.api.tasks.JavaExec
56
import org.gradle.api.tasks.TaskAction
67

@@ -18,10 +19,16 @@ import org.gradle.api.tasks.TaskAction
1819
*/
1920
class ShellTask extends JavaExec {
2021

22+
// Starting in Gradle 6.4, setMain must be called here instead of in a TaskAction method
23+
@Override
24+
Task configure(Closure closure) {
25+
setMain("com.marklogic.groovysh.Main")
26+
return super.configure(closure)
27+
}
28+
2129
@TaskAction
2230
@Override
2331
public void exec() {
24-
setMain("com.marklogic.groovysh.Main")
2532
setStandardInput(System.in)
2633

2734
Project project = getProject()

0 commit comments

Comments
 (0)