Skip to content

Commit 9b91e6c

Browse files
authored
Merge pull request #521 from jamesagardner/mlUnitTest-nested-test-suites
Test Results for Nested Test Suites
2 parents 5009f12 + 018759b commit 9b91e6c

File tree

2 files changed

+33
-1
lines changed

2 files changed

+33
-1
lines changed

src/main/groovy/com/marklogic/gradle/task/test/UnitTestTask.groovy

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ class UnitTestTask extends MarkLogicTask {
9090
testsFailed = true
9191
}
9292
String xml = suite.getXml()
93-
String filename = "TEST-" + suite.getName() + ".xml"
93+
String filename = "TEST-" + escapeFilename(suite.getName()) + ".xml"
9494
org.springframework.util.FileCopyUtils.copy(xml.getBytes(), new File(resultsDir, filename))
9595
fileCount++;
9696
}
@@ -105,4 +105,8 @@ class UnitTestTask extends MarkLogicTask {
105105
client.release()
106106
}
107107
}
108+
109+
static String escapeFilename(String filename) {
110+
return filename.replaceAll("(/|\\\\)", ".")
111+
}
108112
}
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
package com.marklogic.gradle
2+
3+
import org.junit.Test
4+
import com.marklogic.gradle.task.test.UnitTestTask
5+
6+
class UnitTestTaskTest extends GroovyTestCase {
7+
8+
9+
@Test
10+
void testEscapingJavascriptFilenames() {
11+
assertEquals("nestedTest.filename.sjs", UnitTestTask.escapeFilename("nestedTest/filename.sjs"))
12+
assertEquals("nestedTest.filename.sjs", UnitTestTask.escapeFilename("nestedTest\\filename.sjs"))
13+
assertEquals("nestedTest.doubleNestedTest.filenameWithDetails.sjs",
14+
UnitTestTask.escapeFilename("nestedTest/doubleNestedTest/filenameWithDetails.sjs"))
15+
assertEquals("nestedTest.doubleNestedTest.filenameWithDetails.sjs",
16+
UnitTestTask.escapeFilename("nestedTest\\doubleNestedTest\\filenameWithDetails.sjs"))
17+
}
18+
19+
@Test
20+
public void testEscapingXqueryFilenames() {
21+
assertEquals("nested-test.filename.xqy", UnitTestTask.escapeFilename("nested-test/filename.xqy"))
22+
assertEquals("nested-test.filename.xqy", UnitTestTask.escapeFilename("nested-test\\filename.xqy"))
23+
assertEquals("nested-test.double-nested-test.filename-with-details.xqy",
24+
UnitTestTask.escapeFilename("nested-test/double-nested-test/filename-with-details.xqy"))
25+
assertEquals("nested-test.double-nested-test.filename-with-details.xqy",
26+
UnitTestTask.escapeFilename("nested-test\\double-nested-test\\filename-with-details.xqy"))
27+
}
28+
}

0 commit comments

Comments
 (0)