#117 Throwing a friendly error message when permissions string is invalid

Author: rjrudin

src/main/java/com/marklogic/client/ext/util/DefaultDocumentPermissionsParser.java

@@ -12,6 +12,10 @@ public void parsePermissions(String str, DocumentPermissions permissions) {
             String[] tokens = str.split(",");
             for (int i = 0; i < tokens.length; i += 2) {
                 String role = tokens[i];
+                if (i + 1 >= tokens.length) {
+                	throw new IllegalArgumentException("Unable to parse permissions string, which must be a comma-separated " +
+		                "list of role names and capabilities - i.e. role1,read,role2,update,role3,execute; string: " + str);
+                }
                 String capability = tokens[i + 1];
                 Capability c = null;
                 if (capability.equals("execute")) {

src/test/java/com/marklogic/client/ext/util/ParseDocumentPermissionsTest.java

@@ -19,4 +19,16 @@ public void test() {
 		assertEquals(2, perms.get("rest-admin").size());
 		assertEquals(1, perms.get("rest-extension-user").size());
 	}
+
+	@Test
+	public void badInput() {
+		String str = "rest-admin,read,rest-admin";
+		try {
+			parser.parsePermissions(str, new DocumentMetadataHandle().getPermissions());
+			fail("An IllegalArgumentException should be thrown because the permissions string is missing a second capability " +
+				"to go with the second role");
+		} catch (IllegalArgumentException ex) {
+			assertTrue(ex.getMessage().startsWith("Unable to parse permissions string"));
+		}
+	}
 }