MLE-15254 : DatabaseClient.eval() returning true when the result is a boolean

Author: anu3990

lib/server-exec.js

@@ -73,10 +73,11 @@ function execOutputTransform(headers, data) {
     value:    data.content
   };
   case 'boolean':
+    const booleanValue = (typeof data.content === 'string')?(data.content.toLowerCase() === 'true'):data.content;
     return {
       format:   'text',
       datatype: primitive,
-      value:    Boolean(data.content)
+      value:    Boolean(booleanValue)
     };
   case 'dateTime':
     return {

test-basic/server-exec.js

@@ -75,7 +75,7 @@ describe('server-side call', function() {
         })
       .catch(done);
     });
-    it('should generate a boolean value', function(done) {
+    it('should generate a boolean value true', function(done) {
       db.eval('true;').result(function(values) {
         values.length.should.equal(1);
         checkValue(values[0], 'text', 'boolean');
@@ -84,6 +84,15 @@ describe('server-side call', function() {
         })
       .catch(done);
     });
+    it('should generate a boolean value false', function(done) {
+      db.eval('false;').result(function(values) {
+        values.length.should.equal(1);
+        checkValue(values[0], 'text', 'boolean');
+          values[0].value.should.equal(false);
+        done();
+      })
+      .catch(error => done(error));
+    });
     it('should generate an integer value', function(done) {
       db.eval('3;').result(function(values) {
         values.length.should.equal(1);