client test for error mapping in the Data Service endpoint

Author: ehennum

test-basic-proxy/lib/negative/badExecutionTest.js

@@ -23,19 +23,48 @@ const BadExecution = require("./badExecution.js");
 describe('bad execution', function() {
   const service = BadExecution.on(testutil.makeClient());
 
-  it('error mapping', function (done) {
-    service.errorMapping()
+  const test = [
+    [406, 'Unacceptable1', "Unacceptable in every way"],
+    [406, 'Unacceptable2', "Unacceptable, that's how you'll stay", "Unacceptable, that's how you'll stay"],
+    [406, 'Unacceptable2', "Unacceptable, that's how you'll stay", null],
+    [406, 'Unacceptable2', "Unacceptable, that's how you'll stay", "Unacceptable no matter how near or far"],
+    [410, 'Absent1',       "You may search this wide world over"],
+    [500, 'Unknown1',      null,                                   "Are the stars out tonight?"]
+  ];
+
+  function runTest(i, done) {
+    if (i === test.length) {
+      done();
+    }
+    const testCase  = test[i];
+
+    const statusCode = testCase[0];
+    const sentCode   = testCase[1];
+    const mappedMsg  = (testCase[2] === null) ? 'Internal Server Error' : testCase[2];
+    const sentMsg    = (testCase.length < 4)  ? null                    : testCase[3];
+    const mappedCode = (testCase[2] === null) ? 'INTERNAL ERROR'        : sentCode;
+
+    service.errorMapping(sentCode, sentMsg)
         .then(output => {
           expect.fail('should not succeed');
           done();
         })
         .catch(err => {
           const errorResponse = err.body.errorResponse;
-          expect(errorResponse.statusCode).to.eql(418);
-          expect(errorResponse.status).to.eql("Status Message For 418");
-          expect(errorResponse.messageCode).to.eql('ERROR_MAPPING');
-          expect(errorResponse.message).to.contain('Test of error mapping');
-          done();
+          // console.log(errorResponse);
+          expect(errorResponse.statusCode).to.eql(statusCode);
+          expect(errorResponse.status).to.eql(mappedMsg);
+          expect(errorResponse.messageCode).to.eql(mappedCode);
+          if (sentMsg !== null) {
+            const inlineMsg = ': fn.error(null, errCode, errMsg); --  ';
+            const msgOffset = errorResponse.message.indexOf(inlineMsg) + inlineMsg.length;
+            expect(errorResponse.message.substring(msgOffset, msgOffset + sentMsg.length)).to.eql(sentMsg);
+          }
+          runTest(i + 1, done);
         });
+  }
+
+  it('error conditions', function (done) {
+    runTest(0, done);
   });
 });

test-basic-proxy/ml-modules/negative/badExecution/errorMapping.api

@@ -1,10 +1,29 @@
 {
   "functionName" : "errorMapping",
-  "errorConditions":[
-    {
-    "errorCode": "ERROR_MAPPING",
-    "httpStatusCode": 418,
-    "errorMessage":"Status Message For 418"
+  "params": [ {
+    "name":     "errCode",
+    "datatype": "string"
+  }, {
+    "name":     "errMsg",
+    "datatype": "string",
+    "nullable": true
+  } ],
+  "return": {
+    "datatype": "jsonDocument",
+    "nullable": true
+  },
+  "errorConditions":[ {
+    "httpStatusCode": 406,
+    "errorCode":      "Unacceptable1",
+    "errorMessage":   "Unacceptable in every way"
+  }, {
+    "httpStatusCode": 406,
+    "errorCode":      "Unacceptable2",
+    "errorMessage":   "Unacceptable, that's how you'll stay"
+  }, {
+    "httpStatusCode": 410,
+    "errorCode":      "Absent1",
+    "errorMessage":   "You may search this wide world over"
     }
   ]
 }

test-basic-proxy/ml-modules/negative/badExecution/errorMapping.sjs

@@ -15,8 +15,15 @@
  */
 'use strict';
 // declareUpdate(); // Note: uncomment if changing the database state
+var errCode; // string
+var errMsg;  // string?
 
-fn.error(null, "ERROR_MAPPING", "Test of error mapping");
+if (errCode == void 0) {
+  errCode = 418;
+  errMsg = 'Status Message For 418';
+}
+
+fn.error(null, errCode, errMsg);
 
 const returnValue = "Error should be thrown before execution reaches this line";
 returnValue;