MLE-24763 Enabling logging test and removing winston

Only using bunyan in logging.js, and that test seems very safe to run, so it's no longer excluded by Jenkinsfile.

Removed the two "test-complete" logging tests that weren't actually doing anything.

Removing winston allows for the "color" and "color-string" overrides to be removed as well as nothing else depends on them.

Author: rjrudin

Jenkinsfile

@@ -16,9 +16,9 @@ def runTests() {
 
 		cd ..
 		rm -rf $WORKSPACE/*.xml || true
-		./node_modules/.bin/mocha --timeout 10000 -R xunit test-basic/ --reporter mocha-junit-reporter --reporter-options mochaFile=$WORKSPACE/test-basic-reports.xml -g \'logging|archivePath\' --invert  || true
+		./node_modules/.bin/mocha --timeout 10000 -R xunit test-basic/ --reporter mocha-junit-reporter --reporter-options mochaFile=$WORKSPACE/test-basic-reports.xml || true
 		./node_modules/.bin/gulp setupProxyTests || true
-		./node_modules/.bin/mocha --timeout 10000 -R xunit test-basic-proxy/lib/**/*.js --reporter mocha-junit-reporter --reporter-options mochaFile=$WORKSPACE/test-basic-proxy-reports.xml -g \'logging|archivePath\' --invert  || true
+		./node_modules/.bin/mocha --timeout 10000 -R xunit test-basic-proxy/lib/**/*.js --reporter mocha-junit-reporter --reporter-options mochaFile=$WORKSPACE/test-basic-proxy-reports.xml || true
 	'''
 	junit '**/*.xml'
 }
@@ -33,8 +33,8 @@ def runDockerCompose(String markLogicDockerImage) {
     cd node-client-api
     echo "Running docker compose with MarkLogic image: ''' + markLogicDockerImage + '''"
     MARKLOGIC_LOGS_VOLUME=/tmp MARKLOGIC_IMAGE=''' + markLogicDockerImage + ''' docker-compose up -d --build
-    echo "Waiting 60s for MarkLogic to be ready to accept connections"
-    sleep 60s;
+    echo "Waiting 90s for MarkLogic to be ready to accept connections"
+    sleep 90s;
 	'''
 }
 
@@ -129,8 +129,7 @@ pipeline {
         runAuditReport()
         runDockerCompose('ml-docker-db-dev-tierpoint.bed-artifactory.bedford.progress.com/marklogic/marklogic-server-ubi:latest-12')
         runTests()
-        // Commenting this out temporarily for faster PR feedback.
-        // runE2ETests()
+        runE2ETests()
       }
       post {
         always {

package-lock.json

@@ -10,6 +10,7 @@
     "doc": "gulp doc",
     "preinstall": "node checkNodeVersion",
     "prestart": "node checkNodeVersion",
+    "pretest": "node checkNodeVersion",
     "test:setup": "node etc/test-setup.js",
     "test:teardown": "node etc/test-teardown.js",
     "test": "gulp test"
@@ -65,8 +66,7 @@
     "read": "^1.0.7",
     "sanitize-html": "^2.13.0",
     "should": "^13.2.3",
-    "stream-to-array": "^2.3.0",
-    "winston": "^3.8.2"
+    "stream-to-array": "^2.3.0"
   },
   "optionalDependencies": {
     "kerberos": "^2.0.1",
@@ -78,10 +78,8 @@
     "chalk": "4.1.2",
     "braces": "3.0.3",
     "brace-expansion": "2.0.2",
-    "color": "5.0.0",
     "color-convert": "3.1.0",
     "color-name": "2.0.0",
-    "color-string": "2.1.0",
     "cross-spawn": "7.0.6",
     "debug": "4.3.6",
     "is-arrayish": "0.3.2",