Skip to content

Commit b9dd9d5

Browse files
committed
MLE-24763 Enabling logging test and removing winston
Only using bunyan in logging.js, and that test seems very safe to run, so it's no longer excluded by Jenkinsfile. Removed the two "test-complete" logging tests that weren't actually doing anything. Removing winston allows for the "color" and "color-string" overrides to be removed as well as nothing else depends on them.
1 parent 305041d commit b9dd9d5

File tree

6 files changed

+7
-290
lines changed

6 files changed

+7
-290
lines changed

Jenkinsfile

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ def runTests() {
1616
1717
cd ..
1818
rm -rf $WORKSPACE/*.xml || true
19-
./node_modules/.bin/mocha --timeout 10000 -R xunit test-basic/ --reporter mocha-junit-reporter --reporter-options mochaFile=$WORKSPACE/test-basic-reports.xml -g \'logging|archivePath\' --invert || true
19+
./node_modules/.bin/mocha --timeout 10000 -R xunit test-basic/ --reporter mocha-junit-reporter --reporter-options mochaFile=$WORKSPACE/test-basic-reports.xml || true
2020
./node_modules/.bin/gulp setupProxyTests || true
21-
./node_modules/.bin/mocha --timeout 10000 -R xunit test-basic-proxy/lib/**/*.js --reporter mocha-junit-reporter --reporter-options mochaFile=$WORKSPACE/test-basic-proxy-reports.xml -g \'logging|archivePath\' --invert || true
21+
./node_modules/.bin/mocha --timeout 10000 -R xunit test-basic-proxy/lib/**/*.js --reporter mocha-junit-reporter --reporter-options mochaFile=$WORKSPACE/test-basic-proxy-reports.xml || true
2222
'''
2323
junit '**/*.xml'
2424
}
@@ -129,8 +129,7 @@ pipeline {
129129
runAuditReport()
130130
runDockerCompose('ml-docker-db-dev-tierpoint.bed-artifactory.bedford.progress.com/marklogic/marklogic-server-ubi:latest-12')
131131
runTests()
132-
// Commenting this out temporarily for faster PR feedback.
133-
// runE2ETests()
132+
runE2ETests()
134133
}
135134
post {
136135
always {

package-lock.json

Lines changed: 1 addition & 207 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,7 @@
6565
"read": "^1.0.7",
6666
"sanitize-html": "^2.13.0",
6767
"should": "^13.2.3",
68-
"stream-to-array": "^2.3.0",
69-
"winston": "^3.8.2"
68+
"stream-to-array": "^2.3.0"
7069
},
7170
"optionalDependencies": {
7271
"kerberos": "^2.0.1",
@@ -78,10 +77,8 @@
7877
"chalk": "4.1.2",
7978
"braces": "3.0.3",
8079
"brace-expansion": "2.0.2",
81-
"color": "5.0.0",
8280
"color-convert": "3.1.0",
8381
"color-name": "2.0.0",
84-
"color-string": "2.1.0",
8582
"cross-spawn": "7.0.6",
8683
"debug": "4.3.6",
8784
"is-arrayish": "0.3.2",

0 commit comments

Comments
 (0)