NODE-121 : Connection error causes Node process to terminate

Author: anu3990

lib/requester.js

@@ -202,9 +202,14 @@ function challengeRequest(operation) {
     operation.logger.debug('response with status %d and %s challenge for %s',
         statusCode1, hasChallenge, challengeOpts.path);
     if ((statusCode1 === 401 && hasChallenge) || (successStatus && !isRead)) {
-      operation.authenticator = (hasChallenge) ? createAuthenticator(
-          operation.client, options.user, options.password, challenge
-          ) : null;
+      try{
+        operation.authenticator = (hasChallenge) ? createAuthenticator(
+            operation.client, options.user, options.password, challenge
+        ) : null;
+
+      } catch(error){
+        request1.emit('error', new Error('Authentication failed.'));
+      }
       authenticatedRequest(operation);
     // should never happen
     } else if (successStatus && isRead) {

test-basic/client.js

@@ -107,4 +107,24 @@ describe('database clients', function() {
     timestamp.value.should.equal('123');
     done();
   });
+  it('should throw Error when server expects DIGEST and authType is CERTIFICATE', function(done) {
+    const db = marklogic.createDatabaseClient({
+      host: "localhost",
+      port: 8015,
+      authType:'certificate'
+    });
+    const query = marklogic.queryBuilder
+        .where(marklogic.ctsQueryBuilder.cts.directoryQuery('/optic/test/'));
+
+    db.documents.query(query)
+        .result(function (documents) {
+          documents.forEach(function (document) {
+          });
+        })
+        .catch(error =>{
+            assert(error.toString().includes('response with invalid 401 status with path: /v1/search'));
+            marklogic.releaseClient(db);
+            done();
+        });
+  });
 });