increased strictness in jshint #30

Author: ehennum

.jshintrc

@@ -1,4 +1,9 @@
 {
   "node":   true,
-  "eqeqeq": true
+  "curly":  true,
+  "eqeqeq": true,
+  "noarg":  true,
+  "nonew":  true,
+  "undef":  true,
+  "unused": true
 }

lib/bluebird-plus.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+'use strict';
 var bluebirdPlus = require('bluebird/js/main/promise')();
 
 // when the last callback in a chain throws an error in the callback code, 

lib/documents.js

@@ -14,8 +14,6 @@
  * limitations under the License.
  */
 'use strict';
-var util     = require("util");
-var deepcopy = require('deepcopy');
 var valcheck = require('core-util-is');
 
 var requester = require('./requester.js');
@@ -77,7 +75,7 @@ function Documents(client) {
  */
 
 /** @ignore */
-function probeOutputTransform(headers) {
+function probeOutputTransform(/*headers, data*/) {
   /*jshint validthis:true */
   var operation = this;
 
@@ -559,8 +557,7 @@ function singleWriteOutputTransform(headers, data) {
 }
 /** @ignore */
 function writeListOutputTransform(headers, data) {
-  /*jshint validthis:true */
-  var operation = this;
+//  var operation = this;
 
   var systemTime = headers.systemTime;
   if (valcheck.isNullOrUndefined(systemTime)) {
@@ -1084,7 +1081,7 @@ function collectMetadata(document) {
 }
 
 /** @ignore */
-function removeOutputTransform(headers, data) {
+function removeOutputTransform(headers/*, data*/) {
   /*jshint validthis:true */
   var operation = this;
 
@@ -1210,7 +1207,7 @@ function removeDocumentImpl(contentOnly, isLegacy, args) {
   return requester.startRequest(operation);
 }
 
-function removeAllOutputTransform(headers, data) {
+function removeAllOutputTransform(/*headers, data*/) {
   /*jshint validthis:true */
   var operation = this;
 
@@ -1705,7 +1702,7 @@ function notNameFilter(key) {
 }
 
 /** @ignore */
-function patchOutputTransform(headers, data) {
+function patchOutputTransform(/*headers, data*/) {
   /*jshint validthis:true */
   var operation = this;
 

lib/extlibs.js

@@ -37,7 +37,7 @@ function pathErrorTransform(message) {
  */
 
 /** @ignore */
-function emptyOutputTransform(headers, data) {
+function emptyOutputTransform(/*headers, data*/) {
   /*jshint validthis:true */
   var operation = this;
 

lib/mlutil.js

@@ -76,26 +76,6 @@ function appendItem(object, key, value) {
   }
 }
 
-// TODO: retire in favour of core utils START
-function isBoolean(value) {
-  return (value instanceof Boolean || (typeof value) === 'boolean');
-}
-function isNumber(value) {
-  return (value instanceof Number || (typeof value) === 'number');
-}
-function isSet(value) {
-  return (value !== null && value !== undefined);
-}
-function isString(value) {
-  return (value instanceof String || (typeof value) === 'string');
-}
-//TODO: retire in favour of core utils END
-
-function equalThis(other) {
-  /*jshint validthis:true */
-  return this === other;
-}
-
 // isolated in function because v8 deoptimizes try/catch
 function parseJSON(raw) {
   try {
@@ -186,20 +166,27 @@ function rootname(filename) {
 }
 
 function identify(arg, withValues) {
-  if (arg === void 0) return 'undefined';
-  if (arg === null)   return 'null';
+  if (arg === void 0) {
+    return 'undefined';
+  }
+  if (arg === null) {
+    return 'null';
+  }
   var typed = typeof arg;
   switch(typed) {
   case 'boolean'  : return withValues ? typed+' '+arg : typed;
   case 'function' : return typed;
   case 'number'   : return withValues ? typed+' '+arg : typed;
   case 'object'   :
-    if (Array.isArray(arg))
+    if (Array.isArray(arg)) {
       return withValues ? 'Array '+JSON.stringify(arg) : 'Array';
-    if (Buffer.isBuffer(arg))
+    }
+    if (Buffer.isBuffer(arg)) {
       return 'Buffer';
-    if (arg instanceof Error)
+    }
+    if (arg instanceof Error) {
       return withValues ? 'Error '+JSON.stringify(arg) : 'Error';
+    }
 
     var prototypeName = Object.prototype.toString.call(arg);
 
@@ -270,10 +257,6 @@ module.exports = {
     Error:               MarkLogicError,
     extension:           extension,
     first:               first,
-    isBoolean:           isBoolean,
-    isNumber:            isNumber,
-    isSet:               isSet,
-    isString:            isString,
     marshal:             marshal,
     multipartBoundary:   multipartBoundary,
     parseJSON:           parseJSON,

lib/resources-config.js

@@ -37,7 +37,7 @@ function nameErrorTransform(message) {
  */
 
 /** @ignore */
-function emptyOutputTransform(headers, data) {
+function emptyOutputTransform(/*headers, data*/) {
   /*jshint validthis:true */
   var operation = this;
 

lib/responder.js

@@ -604,7 +604,7 @@ QueuedReader.prototype.nextReader = function queuedReaderNextReader() {
     readerQueue.pollFirst().pipe(writer);
   }
 };
-QueuedReader.prototype._read = function queuedReaderRead(size) {
+QueuedReader.prototype._read = function queuedReaderRead(/*size*/) {
   var itemQueue = this.itemQueue;
   if (itemQueue === null) {
     return;

lib/rest-server-properties.js

@@ -55,7 +55,7 @@ RESTServerProperties.prototype.read = function readRESTServerProperties() {
 };
 
 /** @ignore */
-function RESTServerPropertiesOutputTransform(headers) {
+function RESTServerPropertiesOutputTransform(/*headers, data*/) {
   /*jshint validthis:true */
   var operation = this;
 

lib/transactions.js

@@ -27,7 +27,7 @@ var Operation = require('./operation.js');
  */
 
 /** @ignore */
-function openOutputTransform(headers, data) {
+function openOutputTransform(/*headers, data*/) {
   /*jshint validthis:true */
   var operation = this;
 
@@ -149,7 +149,7 @@ Transactions.prototype.rollback = function rollbackTransaction(txid) {
 };
 
 /** @ignore */
-function finishOutputTransform(headers, data) {
+function finishOutputTransform(/*headers, data*/) {
   /*jshint validthis:true */
   var operation = this;
 

lib/transforms.js

@@ -37,7 +37,7 @@ function nameErrorTransform(message) {
  */
 
 /** @ignore */
-function emptyOutputTransform(headers, data) {
+function emptyOutputTransform(/*headers, data*/) {
   /*jshint validthis:true */
   var operation = this;