MLE-24733 - Pretty good start at moving from scripts to Gradle for test-complete setup #1006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillFarber
requested review from
anu3990,
rjrudin and
stevebio
as code owners
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates test-complete setup from scripts to Gradle, establishing infrastructure for testing through the temporal tests. The migration introduces Gradle-based database configuration, user/role setup, and automated data loading via curl commands, though approximately 10 tests still fail before reaching temporal tests.
Key changes:
- Gradle-based MarkLogic database and server configuration replacing manual scripts
- Security setup with roles, users, and privileges for test environments
- TDE (Template Driven Extraction) schemas and test data for optic query testing
Reviewed Changes
Copilot reviewed 61 out of 61 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test-complete/nodejs-optic-generate-views.js | Updates database reference from dynamic naming to static 'Schemas' database |
| test-complete-app/src/main/turtle/**/*.ttl | Adds RDF/Turtle test data files for graph-based testing (people relationships, company data) |
| test-complete-app/src/main/ml-schemas/tde/*.tdej | Adds TDE template definitions for view extraction from JSON/XML documents |
| test-complete-app/src/main/ml-modules/root/optic/test/mapperReducer.sjs | Adds mapper/reducer functions for optic query transformations |
| test-complete-app/src/main/ml-data/optic/**/*.{json,xml} | Adds test data files for optic queries (views, triples, lexicons, plans) |
| test-complete-app/src/main/ml-config/**/*.json | Establishes MarkLogic configuration (servers, databases, users, roles) via Gradle |
| test-complete-app/gradle.properties | Configures Gradle properties for ML deployment (modules database, schemas database, REST port) |
| test-complete-app/build.gradle | Adds curl-based tasks to load turtle data post-deployment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rjrudin
previously approved these changes
Oct 20, 2025
There was a problem hiding this comment.
Looks really good! Overall comments because GH is really slow:
- Format planLexicons.json so it's easier to read
- Same for planViews.json
- Format deducedoc1.xml, assuming the whitespace in there isn't important
- Fix copyright in mapperReducer.sjs
- Is that change to nodejs-optic-generate-view.sjs correct? That looks unexpected, since the name of the var is dbModClient.
Once above minor changes are done, merge away.
BillFarber
force-pushed
the
replacingSetupWithGradle
branch
from
382ccba to
e654f24
Compare
I have made nearly all the changes so far without changing the actual results of the setup method. However, one thing I did change is using the Schemas database instead of the "*Modules" database for schemas. So, I needed to change the code here that is uploading a schema. |
…setup This handles *most* of the tests up through the temporal tests. There are still about 10 tests failing before getting to the temporal tests.
BillFarber
force-pushed
the
replacingSetupWithGradle
branch
from
e654f24 to
c4ab796
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles most of the tests up through the temporal tests.
There are still about 10 tests failing before getting to the temporal tests.