MLE-24763 Enabling lint in Jenkinsfile #1015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a very minimal strategy now. There are 3 TODO's for things that ought to become errors soon. Will open separate Jira tickets for those.
rjrudin
requested review from
BillFarber,
anu3990 and
stevebio
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR enables linting in the Jenkinsfile with a minimal strategy by downgrading certain ESLint rules from errors to warnings. The changes allow the lint step to run in CI while deferring fixes for equality checks, unused variables, and var declarations to future PRs.
- Added npm lint script and Jenkinsfile integration with
--quietflag to only fail on errors - Downgraded three ESLint rules (
eqeqeq,no-unused-vars,no-var) from error to warn severity - Added TODO comments indicating these warnings should be addressed in follow-up work
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Added npm lint script to enable running ESLint via npm |
| eslint.config.js | Downgraded three lint rules to warnings with TODO comments for future fixes |
| Jenkinsfile | Added runLint() function and integrated it into the pipeline's dev branch stage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
BillFarber
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a very minimal strategy now. There are 3 TODO's for things that ought to become errors soon. Will open separate Jira tickets for those.