Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 9, 2025

Also moved docker-compose to the root folder for consistency with other repos.

Also moved docker-compose to the root folder for consistency with other repos.
@github-actions
Copy link

github-actions bot commented Oct 9, 2025

Copyright Validation Results
Total: 6 | Passed: 0 | Failed: 0 | Skipped: 6 | at: 2025-10-09 11:58:33 UTC | commit: d97f209

⏭️ Skipped (Excluded) Files

  • .copyrightconfig
  • .env
  • .gitignore
  • CONTRIBUTING.md
  • Jenkinsfile
  • docker-compose.yaml

✅ All files have valid copyright headers!

@rjrudin rjrudin marked this pull request as ready for review October 9, 2025 13:42
@rjrudin rjrudin requested review from Copilot and removed request for BillFarber, anu3990 and stevebio October 9, 2025 13:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates Docker configuration paths and MarkLogic version for pull request testing, moving Docker Compose setup to the root directory for repository consistency.

  • Updated Jenkins pipeline to use latest MarkLogic 12 nightly build instead of 11.3.2
  • Moved docker-compose.yaml from test-app subdirectory to root directory
  • Updated documentation and configuration files to reflect new Docker setup location

Reviewed Changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.

File Description
Jenkinsfile Updated Docker image to MarkLogic 12 nightly and adjusted paths to use root-level docker-compose
CONTRIBUTING.md Updated documentation to reflect docker-compose now running from root directory
.copyrightconfig Added docker-compose.yaml to files excluded from copyright checking

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rjrudin
Copy link
Contributor Author

rjrudin commented Oct 9, 2025

Got the normal failure on "construct json from literals". Also got a failure on "nodejs-temporal-advance-lsqt.js". Going to merge and see if that failure still happens in the regression runs.

@rjrudin rjrudin requested a review from BillFarber October 9, 2025 13:49
@rjrudin rjrudin merged commit b2c2135 into develop Oct 9, 2025
2 of 3 checks passed
@rjrudin rjrudin deleted the feature/bump-ml-version branch October 9, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants