MLE-24230 First batch of package updates #988
Merged
+142
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rjrudin
commented
Oct 15, 2025
rjrudin
commented
- Removed deepcopy, using native Node structuredClone.
- Moved eslint to devDependencies (which removes 50+ dependencies total from the real dependency graph!).
- Upgraded busboy and documented why we're using it instead of dicer (going to use CONTRIBUTING for providing any explanations for things in package.json).
- Removing usage of caret in package.json to avoid accidentally picking up malicious upgrades.
rjrudin
requested review from
BillFarber,
anu3990 and
stevebio
as code owners
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes dependency management by removing unnecessary packages, reorganizing dependencies, and eliminating version ranges to prevent unintended upgrades.
Key Changes:
- Replaced
deepcopypackage with nativestructuredCloneAPI - Moved
eslintfrom dependencies to devDependencies - Removed caret (^) version prefixes and updated package versions
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removed deepcopy and eslint from dependencies, updated package versions without carets, moved eslint to devDependencies |
| lib/values-builder.js | Replaced deepcopy() with native structuredClone() |
| lib/query-builder.js | Replaced deepcopy() with native structuredClone() |
| NOTICE.txt | Removed license entries for deepcopy and eslint, fixed BOM character issue |
| CONTRIBUTING.md | Added documentation explaining the use of @fastify/busboy over dicer |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- Removed deepcopy, using native Node structuredClone. - Moved eslint to devDependencies (which removes 50+ dependencies total from the real dependency graph!). - Upgraded busboy and documented why we're using it instead of dicer (going to use CONTRIBUTING for providing any explanations for things in package.json). - Removing usage of caret in package.json to avoid accidentally picking up malicious upgrades.
rjrudin
force-pushed
the
feature/24230-updates
branch
from
f441f89 to
9f26c8b
Compare
BillFarber
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.