-
Notifications
You must be signed in to change notification settings - Fork 53
MLE-24733 - Adding more information to some test descriptions. #998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLE-24733 - Adding more information to some test descriptions. #998
Conversation
This makes debugging much easier.
|
Copyright Validation Results ✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances test descriptions by appending unique file identifiers to previously identical test suite names, making it easier to identify which test file is running or failing during debugging.
Key Changes:
- Updated
describe()block descriptions across 6 test files to include file-specific identifiers in parentheses
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test-complete/nodejs-dmsdk-xmlFiles-transformAll.js | Added "(nodejs-dmsdk-xmlFiles-transformAll)" to test description |
| test-complete/nodejs-dmsdk-txtFiles-transformAll.js | Added "(nodejs-dmsdk-txtFiles-transformAll)" to test description |
| test-complete/nodejs-dmsdk-transformAll.js | Added "(nodejs-dmsdk-transformAll)" to test description |
| test-complete/nodejs-dmsdk-removeAllUris.js | Added "nodejs-dmsdk-removeAllUris" to test description |
| test-complete/nodejs-dmsdk-queryToTransformAll.js | Added "- nodejs-dmsdk-queryToTransformAll" to test description |
| test-basic/documents-data-movement-transformAll.js | Added "(documents-data-movement-transformAll)" to test description |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| let uris = []; | ||
|
|
||
| describe('Functional tests - data movement removeAllUris', function () { | ||
| describe('Functional tests - data movement - nodejs-dmsdk-removeAllUris', function () { |
Copilot
AI
Oct 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Inconsistent formatting compared to other test descriptions. While most files use parentheses to wrap the file identifier (e.g., '(nodejs-dmsdk-transformAll)'), this file uses hyphens. Consider using 'Functional tests - data movement (nodejs-dmsdk-removeAllUris)' for consistency.
| describe('Functional tests - data movement - nodejs-dmsdk-removeAllUris', function () { | |
| describe('Functional tests - data movement (nodejs-dmsdk-removeAllUris)', function () { |
| const query = q.where(ctsQb.cts.directoryQuery('/test/dataMovement/requests/transformAll/')); | ||
|
|
||
| describe('data movement transformAll', function () { | ||
| describe('data movement transformAll - nodejs-dmsdk-queryToTransformAll', function () { |
Copilot
AI
Oct 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Inconsistent formatting compared to other test descriptions. While most files use parentheses to wrap the file identifier (e.g., '(nodejs-dmsdk-transformAll)'), this file uses a hyphen separator. Consider using 'data movement transformAll (nodejs-dmsdk-queryToTransformAll)' for consistency.
| describe('data movement transformAll - nodejs-dmsdk-queryToTransformAll', function () { | |
| describe('data movement transformAll (nodejs-dmsdk-queryToTransformAll)', function () { |
The previous descriptions were identical across multiple files. This makes debugging much easier.