Skip to content

Commit 63fc7b9

Browse files
committed
fix: support vitest with istanbul
1 parent 6f9d13c commit 63fc7b9

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

.changeset/cuddly-bottles-jog.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@marko/vite": patch
3+
---
4+
5+
Support vitest with istanbul codecoverage.

src/index.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -665,7 +665,7 @@ export default function markoPlugin(opts: Options = {}): vite.Plugin[] {
665665
: await this.resolve(importee, importer, resolveOpts);
666666

667667
if (resolved) {
668-
resolved.id = stripVersionAndTimeStamp(resolved.id) + importeeQuery;
668+
resolved.id = stripViteQueries(resolved.id) + importeeQuery;
669669
}
670670

671671
return resolved;
@@ -690,7 +690,7 @@ export default function markoPlugin(opts: Options = {}): vite.Plugin[] {
690690
return null;
691691
},
692692
async load(rawId) {
693-
const id = stripVersionAndTimeStamp(rawId);
693+
const id = stripViteQueries(rawId);
694694

695695
if (id === renderAssetsRuntimeId) {
696696
return renderAssetsRuntimeCode;
@@ -737,7 +737,7 @@ export default function markoPlugin(opts: Options = {}): vite.Plugin[] {
737737
return virtualFiles.get(id) || null;
738738
},
739739
async transform(source, rawId, ssr) {
740-
let id = stripVersionAndTimeStamp(rawId);
740+
let id = stripViteQueries(rawId);
741741
const info = isBuild ? this.getModuleInfo(id) : undefined;
742742
const arcSourceId = info?.meta.arcSourceId;
743743
if (arcSourceId) {
@@ -1107,11 +1107,13 @@ function isEmpty(obj: unknown) {
11071107
return true;
11081108
}
11091109

1110-
function stripVersionAndTimeStamp(id: string) {
1110+
function stripViteQueries(id: string) {
11111111
const queryStart = id.indexOf("?");
11121112
if (queryStart === -1) return id;
11131113
const url = id.slice(0, queryStart);
1114-
const query = id.slice(queryStart + 1).replace(/(?:^|[&])[vt]=[^&]+/g, "");
1114+
const query = id
1115+
.slice(queryStart + 1)
1116+
.replace(/(?:^|[&])(?:cache|[vt])=[^&]+/g, "");
11151117
if (query) return `${url}?${query}`;
11161118
return url;
11171119
}

0 commit comments

Comments
 (0)