Skip to content

Commit c3ff28c

Browse files
committed
chore: update deps, ensure close related updates are in final step
1 parent 242e990 commit c3ff28c

File tree

9 files changed

+1249
-1431
lines changed

9 files changed

+1249
-1431
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
strategy:
3636
fail-fast: false
3737
matrix:
38-
node: [18, 20]
38+
node: [22]
3939
steps:
4040
- name: Checkout code
4141
uses: actions/checkout@v4

package-lock.json

Lines changed: 1115 additions & 1409 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -40,35 +40,35 @@
4040
"test:update": "npm test -- --update"
4141
},
4242
"devDependencies": {
43-
"@changesets/changelog-github": "^0.5.0",
44-
"@changesets/cli": "^2.27.10",
45-
"@eslint/js": "^9.15.0",
46-
"@types/diff": "^6.0.0",
43+
"@changesets/changelog-github": "^0.5.1",
44+
"@changesets/cli": "^2.29.5",
45+
"@eslint/js": "^9.30.1",
46+
"@types/diff": "^8.0.0",
4747
"@types/diffable-html": "^5.0.2",
4848
"@types/istanbul-lib-instrument": "^1.7.7",
4949
"@types/mocha": "^10.0.10",
50-
"@types/node": "^22.10.0",
50+
"@types/node": "^22.16.0",
5151
"@types/prettier": "^3.0.0",
5252
"cross-env": "^7.0.3",
53-
"diff": "^7.0.0",
53+
"diff": "^8.0.2",
5454
"diffable-html": "^5.0.0",
55-
"esbuild": "^0.24.0",
56-
"eslint": "^9.15.0",
55+
"esbuild": "^0.25.5",
56+
"eslint": "^9.30.1",
5757
"eslint-formatter-unix": "^8.40.0",
5858
"eslint-plugin-simple-import-sort": "^12.1.1",
59-
"fast-glob": "^3.3.2",
60-
"globals": "^15.12.0",
59+
"fast-glob": "^3.3.3",
60+
"globals": "^16.3.0",
6161
"husky": "^9.1.7",
6262
"istanbul-lib-instrument": "^6.0.3",
63-
"lint-staged": "^15.2.10",
64-
"mocha": "^10.8.2",
63+
"lint-staged": "^16.1.2",
64+
"mocha": "^11.7.1",
6565
"mocha-snap": "^5.0.0",
6666
"nyc": "^17.1.0",
67-
"playwright": "^1.49.0",
68-
"prettier": "^3.4.1",
69-
"prettier-plugin-packagejson": "^2.5.6",
70-
"tsx": "^4.19.2",
71-
"typescript": "^5.7.2",
72-
"typescript-eslint": "^8.16.0"
67+
"playwright": "^1.53.2",
68+
"prettier": "^3.6.2",
69+
"prettier-plugin-packagejson": "^2.5.18",
70+
"tsx": "^4.20.3",
71+
"typescript": "^5.8.3",
72+
"typescript-eslint": "^8.35.1"
7373
}
7474
}

src/__tests__/__snapshots__/blocking-scripts.expected.md

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,3 +90,28 @@ Embedded App.
9090
After blocking.
9191
```
9292

93+
# Step 1
94+
95+
```html
96+
Embedded App.
97+
<script>
98+
window.inlineScriptValues = []
99+
</script>
100+
<script src="/external.js?value=a">
101+
</script>
102+
<script>
103+
inlineScriptValues.push(0, scriptValues.at(-1));
104+
</script>
105+
<script src="/external.js?value=b">
106+
</script>
107+
<script>
108+
inlineScriptValues.push(1, scriptValues.at(-1));
109+
</script>
110+
<script src="/external.js?value=c">
111+
</script>
112+
<script>
113+
inlineScriptValues.push(2, scriptValues.at(-1));
114+
</script>
115+
After blocking.
116+
```
117+

src/__tests__/__snapshots__/blocking-styles.expected.md

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,3 +108,34 @@ Embedded App.
108108
After blocking.
109109
```
110110

111+
# Step 1
112+
113+
```html
114+
Embedded App.
115+
<script>
116+
window.inlineScriptValues = []
117+
</script>
118+
<link
119+
rel="stylesheet"
120+
href="/external.css?color=rgb(255, 0, 0)"
121+
>
122+
<script>
123+
inlineScriptValues.push(getComputedStyle(document.body).color);
124+
</script>
125+
<link
126+
rel="stylesheet"
127+
href="/external.css?color=rgb(0, 255, 0)"
128+
>
129+
<script>
130+
inlineScriptValues.push(getComputedStyle(document.body).color);
131+
</script>
132+
<link
133+
rel="stylesheet"
134+
href="/external.css?color=rgb(0, 0, 255)"
135+
>
136+
<script>
137+
inlineScriptValues.push(getComputedStyle(document.body).color);
138+
</script>
139+
After blocking.
140+
```
141+

src/__tests__/__snapshots__/crossorigin-and-integrity-preloads.expected.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,3 +80,22 @@ Embedded App.
8080
After blocking.
8181
```
8282

83+
# Step 1
84+
85+
```html
86+
Embedded App.
87+
<script src="/external.js?value=a">
88+
</script>
89+
<script
90+
src="/external.js?value=b"
91+
crossorigin="use-credentials"
92+
>
93+
</script>
94+
<script
95+
src="/external.js?value=c"
96+
integrity="sha384-oqVuAfXRKap7fdgcCY5uykM6+R9GqQ8K/uxy9rx7HNQlGYl1kPzQho1wx4JwY8wC"
97+
>
98+
</script>
99+
After blocking.
100+
```
101+

src/__tests__/__snapshots__/inline-scripts.expected.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,13 @@ Embedded App.
2222
After Script.
2323
```
2424

25+
# Step 3
26+
27+
```html
28+
Embedded App.
29+
<script>
30+
scriptValues = ["a", "b"];
31+
</script>
32+
After Script.
33+
```
34+

src/__tests__/__snapshots__/script-preloads.expected.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,3 +95,27 @@ Embedded App.
9595
After blocking.
9696
```
9797

98+
# Step 1
99+
100+
```html
101+
Embedded App.
102+
<script src="/external.js?value=a">
103+
</script>
104+
<script
105+
src="/external.js?value=b"
106+
async
107+
>
108+
</script>
109+
<script
110+
src="/external.js?value=c"
111+
nomodule
112+
>
113+
</script>
114+
<script
115+
src="/external.js?value=d"
116+
type="module"
117+
>
118+
</script>
119+
After blocking.
120+
```
121+

src/__tests__/fixture.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,19 @@ export default (step?: Step[] | Step) => {
3131

3232
let snapshot = "";
3333
let stepId = 0;
34-
for (const step of steps) {
34+
for (let i = 0; i < steps.length; i++) {
35+
const step = steps[i];
3536
await waitForPendingRequests(
3637
page,
3738
typeof step === "function"
3839
? step
3940
: () => page.evaluate((step) => writer.write(step), step),
4041
);
4142

43+
if (i === steps.length - 1) {
44+
await page.evaluate(() => writer.close());
45+
}
46+
4247
await new Promise((r) => setTimeout(r, 500));
4348

4449
if (changes.length) {
@@ -50,8 +55,6 @@ export default (step?: Step[] | Step) => {
5055
}
5156
}
5257

53-
await page.evaluate(() => writer.close());
54-
5558
assert.ok(
5659
!changes.length,
5760
"Should not have any mutations after we've finished writing.",

0 commit comments

Comments
 (0)