add authentication tests

Author: markolbert

J4JMapLibrary/projections/google/GoogleMapsProjection.cs

@@ -29,6 +29,8 @@ namespace J4JSoftware.J4JMapLibrary;
 [ Projection( "GoogleMaps" ) ]
 public sealed class GoogleMapsProjection : StaticProjection
 {
+    private bool _pendingInitializtion;
+
     public GoogleMapsProjection(
         ILoggerFactory? loggerFactory = null
     )
@@ -92,17 +94,28 @@ protected override bool ValidateCredentials( object credentials )
 
         Initialized = false;
 
-        ApiKey = ((GoogleCredentials) Credentials!).ApiKey;
-        Signature = ((GoogleCredentials)Credentials).SignatureSecret;
+        ApiKey = ( (GoogleCredentials) Credentials! ).ApiKey;
+        Signature = ( (GoogleCredentials) Credentials ).SignatureSecret;
+
+        // the only way to check Google credentials is to try and retrieve a map image
+        // sadly, that can fail for reasons other than invalid credentials
+        // we also have to temporarily override the initialized check
+        _pendingInitializtion = true;
+        
+        var testBytes = await GetImageAsync( MapTile.CreateStaticMapTile( this, 0, 0, 0, LoggerFactory ), ctx );
+        Initialized = testBytes != null;
+        
+        _pendingInitializtion = false;
 
-        Initialized = true;
+        if( !Initialized )
+            Logger?.LogError( "Failed to retrieve map image, Google credentials may be invalid" );
 
-        return true;
+        return Initialized;
     }
 
     protected override HttpRequestMessage? CreateMessage( MapTile mapTile )
     {
-        if( !Initialized )
+        if( !_pendingInitializtion && !Initialized )
         {
             Logger?.LogError( "Trying to create image retrieval HttpRequestMessage when uninitialized" );
             return null;

J4JMapLibrary/projections/openmap/OpenStreetMapsProjection.cs

@@ -65,7 +65,12 @@ protected override bool ValidateCredentials(object credentials)
 
         UserAgent = ( (OpenStreetCredentials) Credentials! ).UserAgent;
 
-        Initialized = true;
+        // user agent must be unique, but this is all we can do to check it
+        Initialized = !string.IsNullOrEmpty( UserAgent );
+
+        if( !Initialized )
+            Logger?.LogError("Empty or undefined user agent value");
+
         return Initialized;
     }
 

J4JMapLibrary/projections/openmap/OpenTopoMapsProjection.cs

@@ -66,7 +66,12 @@ protected override bool ValidateCredentials(object credentials)
 
         UserAgent = ( (OpenTopoCredentials) Credentials! ).UserAgent;
 
-        Initialized = true;
+        // user agent must be unique, but this is all we can do to check it
+        Initialized = !string.IsNullOrEmpty(UserAgent);
+
+        if (!Initialized)
+            Logger?.LogError("Empty or undefined user agent value");
+
         return Initialized;
     }