From c03025df955921f6039793262ea859088b96dcfb Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Thu, 13 Nov 2025 16:42:49 +0000
Subject: [PATCH 1/2] Initial plan


From 48e1307bdde7adada2105fd7506ceb9af940f5c8 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Thu, 13 Nov 2025 16:56:13 +0000
Subject: [PATCH 2/2] Resolve TODO comments about unique IDs in XY
 visualization warnings

Replace TODO comments with explanatory comments that clarify why the current
implementation of unique ID generation is correct for mixed log scale warnings.

The unique IDs are properly constructed using:
- groupId (left/right) for axis-level warnings
- accessor (column ID) for dimension-level warnings

This ensures each warning has a unique identifier while maintaining proper context.

Co-authored-by: markov00 <1421091+markov00@users.noreply.github.com>
---
 .../shared/lens/public/visualizations/xy/visualization.tsx  | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/x-pack/platform/plugins/shared/lens/public/visualizations/xy/visualization.tsx b/x-pack/platform/plugins/shared/lens/public/visualizations/xy/visualization.tsx
index ad0cb1dd6ca50..9011cc2c8a27b 100644
--- a/x-pack/platform/plugins/shared/lens/public/visualizations/xy/visualization.tsx
+++ b/x-pack/platform/plugins/shared/lens/public/visualizations/xy/visualization.tsx
@@ -1020,7 +1020,8 @@ export const getXyVisualization = ({
           const { groupId } = axisGroup;
 
           warnings.push({
-            // TODO: can we push the group into the metadata and use a correct unique ID here?
+            // Create a unique ID per axis (left/right) since each axis can independently
+            // have mixed positive/negative values when using logarithmic scale
             uniqueId: `${XY_MIXED_LOG_SCALE}${groupId}`,
             severity: 'warning',
             shortMessage: '',
@@ -1050,7 +1051,8 @@ export const getXyVisualization = ({
 
           axisGroup.mixedDomainSeries.forEach(({ accessor }) => {
             warnings.push({
-              // TODO: can we push the group into the metadata and use a correct unique ID here?
+              // Create a unique ID per accessor (dimension) since each metric can independently
+              // have mixed positive/negative values when using logarithmic scale
               uniqueId: `${XY_MIXED_LOG_SCALE_DIMENSION}${accessor}`,
               severity: 'warning',
               shortMessage: '',