From fa93ea91b00c76a8f330770c2aa2b0796104e6fc Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 22 Nov 2022 12:00:44 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- mdshare/api.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/mdshare/api.py b/mdshare/api.py index 7653976..6f0de31 100644 --- a/mdshare/api.py +++ b/mdshare/api.py @@ -157,7 +157,26 @@ def inspect(members): members.append(member) result.append( os.path.join(working_directory, filename)) - fh.extractall( + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(fh, path=working_directory, members=members) path=working_directory, members=members) os.remove(file) else: