Added some negative testing and error catching for custom colour

Author: marksweb

setup.cfg

@@ -1,6 +1,6 @@
 [metadata]
 name = django-sys-indicator
-version = 0.3.0
+version = 0.4.0
 url = https://github.com/marksweb/django-sys-indicator
 description = A system/environment indicator for django
 long_description = file: README.md

src/django_sys_indicator/conf.py

@@ -30,7 +30,7 @@ def SYSTEM_INDICATOR_LABEL(self) -> str:  # noqa: N802
         return getattr(dj_settings, "SYSTEM_INDICATOR_LABEL", 'localhost')
 
     @property
-    def SYSTEM_INDICATOR_COLORS(self) -> str:  # noqa: N802
+    def SYSTEM_INDICATOR_COLORS(self) -> dict:  # noqa: N802
         return getattr(dj_settings, "SYSTEM_INDICATOR_COLORS", DEFAULT_COLOURS)
 
     @property

src/django_sys_indicator/utils.py

@@ -6,13 +6,15 @@
 
 
 def django_sys_indicator_tag() -> str:
-    if not settings.SYSTEM_INDICATOR_ENABLED:
-        return ""
-
     template_name = 'django_sys_indicator/system_indicator.html'
-    color, border_color = settings.SYSTEM_INDICATOR_COLORS[
-        settings.SYSTEM_INDICATOR_COLOR
-    ]
+
+    try:
+        color, border_color = settings.SYSTEM_INDICATOR_COLORS[
+            settings.SYSTEM_INDICATOR_COLOR
+        ]
+    except KeyError:
+        # Invalid colour chosen
+        color, border_color = settings.SYSTEM_INDICATOR_COLORS['red']
     return render_to_string(
         template_name,
         {

tests/test_middleware.py

@@ -56,3 +56,27 @@ def test_enabled_orange(self):
         assert settings.SYSTEM_INDICATOR_LABEL in content
         assert border_color in content
         assert color in content
+
+    @override_settings(SYSTEM_INDICATOR_ENABLED=True, SYSTEM_INDICATOR_COLOR='black')
+    def test_invalid_colour(self):
+        response = self.middleware(self.request)
+        content = response.content.decode(response.charset)
+        # Invalid colour results in red as a default
+        color, border_color = settings.SYSTEM_INDICATOR_COLORS['red']
+
+        assert settings.SYSTEM_INDICATOR_LABEL in content
+        assert border_color in content
+        assert color in content
+
+    @override_settings(SYSTEM_INDICATOR_ENABLED=True, SYSTEM_INDICATOR_LABEL=123)
+    def test_int_label(self):
+        response = self.middleware(self.request)
+        content = response.content.decode(response.charset)
+        color, border_color = settings.SYSTEM_INDICATOR_COLORS[
+            settings.SYSTEM_INDICATOR_COLOR
+        ]
+
+        # cast to string here because of the assert against the string content
+        assert str(settings.SYSTEM_INDICATOR_LABEL) in content
+        assert border_color in content
+        assert color in content