chore: Bump coverage to 100% (#49)

marksweb · web-flow · commit ceb5eb3ae13c · 2024-11-05T00:02:56.000Z
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -77,11 +77,11 @@ jobs:
           pattern: coverage-data-*
           merge-multiple: true
 
-      - name: Combine coverage and fail if it's <96%
+      - name: Combine coverage and fail if it's <100%
         run: |
           python -m coverage combine
           python -m coverage html --skip-covered --skip-empty
-          python -m coverage report --fail-under=96
+          python -m coverage report --fail-under=100
           echo "## Coverage summary" >> $GITHUB_STEP_SUMMARY
           python -m coverage report --format=markdown >> $GITHUB_STEP_SUMMARY
 
diff --git a/src/django_sys_indicator/conf.py b/src/django_sys_indicator/conf.py
@@ -34,9 +34,5 @@ def SYSTEM_INDICATOR_LABEL(self) -> str:  # noqa: N802
     def SYSTEM_INDICATOR_COLORS(self) -> dict[str, tuple[str, str]]:  # noqa: N802
         return getattr(dj_settings, "SYSTEM_INDICATOR_COLORS", DEFAULT_COLOURS)
 
-    @property
-    def SYSTEM_INDICATOR_EXCLUSIONS(self) -> Sequence[str]:  # noqa: N802
-        return getattr(dj_settings, "SYSTEM_INDICATOR_EXCLUSIONS", [])
-
 
 settings = Settings()
diff --git a/tests/settings.py b/tests/settings.py
@@ -15,6 +15,8 @@
     },
 }
 
+INSTALLED_APPS = ["django_sys_indicator"]
+
 TEMPLATES = [
     {
         "BACKEND": "django.template.backends.django.DjangoTemplates",
@@ -35,3 +37,7 @@
     USE_L10N = True
 
 USE_TZ = True
+
+PASSWORD_HASHERS = [
+    "django.contrib.auth.hashers.MD5PasswordHasher",
+]
diff --git a/tests/test_middleware.py b/tests/test_middleware.py
@@ -22,6 +22,14 @@ def get_response(request: HttpRequest) -> HttpResponse:
 
         self.middleware = SystemIndicatorMiddleware(get_response)
 
+    @override_settings(SYSTEM_INDICATOR_ENABLED=True)
+    def test_content_length(self):
+        self.response["Content-Length"] = 6553
+
+        response = self.middleware(self.request)
+        content = response.content.decode(response.charset)
+        assert settings.SYSTEM_INDICATOR_LABEL in content
+
     @override_settings(SYSTEM_INDICATOR_ENABLED=True)
     def test_invalid_content(self):
         self.response = HttpResponse("<html><body></body></html>")

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,8 @@`
`15`	`15`	`},`
`16`	`16`	`}`
`17`	`17`
	`18`	`+INSTALLED_APPS = ["django_sys_indicator"]`
	`19`	`+`
`18`	`20`	`TEMPLATES = [`
`19`	`21`	`{`
`20`	`22`	`"BACKEND": "django.template.backends.django.DjangoTemplates",`
`@@ -35,3 +37,7 @@`
`35`	`37`	`USE_L10N = True`
`36`	`38`
`37`	`39`	`USE_TZ = True`
	`40`	`+`
	`41`	`+PASSWORD_HASHERS = [`
	`42`	`+ "django.contrib.auth.hashers.MD5PasswordHasher",`
	`43`	`+]`