parsing: remove debug check

markus-wa · markus-wa · commit 03b772fa0c41 · 2019-06-12T15:59:52.000+02:00
the NOP function should be eliminated by the compiler.
diff --git a/debug_off.go b/debug_off.go
@@ -9,8 +9,6 @@ import (
 	st "github.com/markus-wa/demoinfocs-golang/sendtables"
 )
 
-const isDebug = false
-
 func debugGameEvent(descriptor *msg.CSVCMsg_GameEventListDescriptorT, ge *msg.CSVCMsg_GameEvent) {
 	// NOP
 }
diff --git a/debug_on.go b/debug_on.go
@@ -11,8 +11,6 @@ import (
 	st "github.com/markus-wa/demoinfocs-golang/sendtables"
 )
 
-const isDebug = true
-
 const (
 	yes = "YES"
 	no  = "NO"
diff --git a/parsing.go b/parsing.go
@@ -295,9 +295,7 @@ func (p *Parser) parsePacket() {
 				name = msg.SVC_Messages_name[int32(cmd)]
 			}
 
-			if isDebug {
-				debugUnhandledMessage(cmd, name)
-			}
+			debugUnhandledMessage(cmd, name)
 
 			if name != "" {
 				// Handle additional net-messages as defined by the user

Original file line number	Diff line number	Diff line change
`@@ -9,8 +9,6 @@ import (`
`9`	`9`	`st "github.com/markus-wa/demoinfocs-golang/sendtables"`
`10`	`10`	`)`
`11`	`11`
`12`		`-const isDebug = false`
`13`		`-`
`14`	`12`	`func debugGameEvent(descriptor msg.CSVCMsg_GameEventListDescriptorT, ge msg.CSVCMsg_GameEvent) {`
`15`	`13`	`// NOP`
`16`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,6 @@ import (`
`11`	`11`	`st "github.com/markus-wa/demoinfocs-golang/sendtables"`
`12`	`12`	`)`
`13`	`13`
`14`		`-const isDebug = true`
`15`		`-`
`16`	`14`	`const (`
`17`	`15`	`yes = "YES"`
`18`	`16`	`no = "NO"`
Original file line number	Diff line number	Diff line change
`@@ -295,9 +295,7 @@ func (p *Parser) parsePacket() {`
`295`	`295`	`name = msg.SVC_Messages_name[int32(cmd)]`
`296`	`296`	`}`
`297`	`297`
`298`		`- if isDebug {`
`299`		`- debugUnhandledMessage(cmd, name)`
`300`		`- }`
	`298`	`+ debugUnhandledMessage(cmd, name)`
`301`	`299`
`302`	`300`	`if name != "" {`
`303`	`301`	`// Handle additional net-messages as defined by the user`