Nicer for loop

markus-wa · markus-wa · commit 06a397c4af8d · 2018-07-19T22:11:33.000+02:00
diff --git a/sendtables/propdecoder.go b/sendtables/propdecoder.go
@@ -291,17 +291,15 @@ func (propertyDecoder) decodeArray(fProp *FlattenedPropEntry, reader *bit.BitRea
 		numBits++
 	}
 
-	nElements := int(reader.ReadInt(numBits))
-
-	res := make([]PropValue, 0, nElements)
+	res := make([]PropValue, int(reader.ReadInt(numBits)))
 
 	tmp := &PropertyEntry{
 		entry: &FlattenedPropEntry{prop: fProp.arrayElementProp},
 	}
 
-	for i := 0; i < nElements; i++ {
+	for i := range res {
 		propDecoder.decodeProp(tmp, reader)
-		res = append(res, tmp.value)
+		res[i] = tmp.value
 	}
 
 	return res

Original file line number	Diff line number	Diff line change
`@@ -291,17 +291,15 @@ func (propertyDecoder) decodeArray(fProp FlattenedPropEntry, reader bit.BitRea`
`291`	`291`	`numBits++`
`292`	`292`	`}`
`293`	`293`
`294`		`- nElements := int(reader.ReadInt(numBits))`
`295`		`-`
`296`		`- res := make([]PropValue, 0, nElements)`
	`294`	`+ res := make([]PropValue, int(reader.ReadInt(numBits)))`
`297`	`295`
`298`	`296`	`tmp := &PropertyEntry{`
`299`	`297`	`entry: &FlattenedPropEntry{prop: fProp.arrayElementProp},`
`300`	`298`	`}`
`301`	`299`
`302`		`- for i := 0; i < nElements; i++ {`
	`300`	`+ for i := range res {`
`303`	`301`	`propDecoder.decodeProp(tmp, reader)`
`304`		`- res = append(res, tmp.value)`
	`302`	`+ res[i] = tmp.value`
`305`	`303`	`}`
`306`	`304`
`307`	`305`	`return res`