perf: reduce memory usage + increase speed ~10%

Author: markus-wa

pkg/demoinfocs/sendtables2/entity.go

@@ -437,13 +437,25 @@ func (e *Entity) readFields(r *reader, paths *[]*fieldPath) {
 		val := decoder(r)
 
 		if base && (f.model == fieldModelVariableArray || f.model == fieldModelVariableTable) {
-			oldFS := e.state.get(fp)
-			fs := newFieldState()
+			fs := fieldState{}
 
-			fs.state = make([]interface{}, val.(uint64))
+			oldFS, ok := e.state.get(fp).(*fieldState)
 
-			if oldFS != nil {
-				copy(fs.state, oldFS.(*fieldState).state[:min(len(fs.state), len(oldFS.(*fieldState).state))])
+			if !ok {
+				fs.state = make([]any, val.(uint64))
+			}
+
+			if ok {
+				if uint64(len(oldFS.state)) >= val.(uint64) {
+					fs.state = oldFS.state[:val.(uint64)]
+				} else {
+					if uint64(cap(oldFS.state)) >= val.(uint64) {
+						fs.state = oldFS.state[:val.(uint64)]
+					} else {
+						fs.state = make([]any, val.(uint64))
+						copy(fs.state, oldFS.state)
+					}
+				}
 			}
 
 			e.state.set(fp, fs)

pkg/demoinfocs/sendtables2/field_state.go

@@ -1,18 +1,19 @@
 package sendtables2
 
 type fieldState struct {
-	state []interface{}
+	state []any
 }
 
 func newFieldState() *fieldState {
 	return &fieldState{
-		state: make([]interface{}, 8),
+		state: make([]any, 8),
 	}
 }
 
-func (s *fieldState) get(fp *fieldPath) interface{} {
+func (s *fieldState) get(fp *fieldPath) any {
 	x := s
 	z := 0
+
 	for i := 0; i <= fp.last; i++ {
 		z = fp.path[i]
 		if len(x.state) < z+1 {
@@ -26,20 +27,21 @@ func (s *fieldState) get(fp *fieldPath) interface{} {
 		}
 		x = x.state[z].(*fieldState)
 	}
+
 	return nil
 }
 
-func (s *fieldState) set(fp *fieldPath, v interface{}) {
+func (s *fieldState) set(fp *fieldPath, v any) {
 	x := s
 	z := 0
 
 	for i := 0; i <= fp.last; i++ {
 		z = fp.path[i]
 
 		if y := len(x.state); y <= z {
-			newCap := max(z+2, y*2)
-			if z+2 > cap(x.state) {
-				newSlice := make([]interface{}, z+1, newCap)
+			newCap := max(z*2, y*2)
+			if z+1 > cap(x.state) {
+				newSlice := make([]any, z+1, newCap)
 				copy(newSlice, x.state)
 				x.state = newSlice
 			} else {

pkg/demoinfocs/sendtables2/serializer.go

@@ -86,10 +86,12 @@ func (s *serializer) getFieldPathForName(fp *fieldPath, name string) bool {
 
 func (s *serializer) getFieldPaths(fp *fieldPath, state *fieldState) []*fieldPath {
 	results := make([]*fieldPath, 0, 4)
+
 	for i, f := range s.fields {
 		fp.path[fp.last] = i
 		results = append(results, f.getFieldPaths(fp, state)...)
 	}
+
 	return results
 }