Increase test coverage

* Removed dead code
* Added additional ErrHeaderNotParsed test for ParseNextFrame

Author: markus-wa

demoinfocs_test.go

@@ -286,6 +286,11 @@ func TestHeaderNotParsed(t *testing.T) {
 
 	p := dem.NewParser(f)
 
+	_, err = p.ParseNextFrame()
+	if err != dem.ErrHeaderNotParsed {
+		t.Fatal("Tried to parse tick before header but error was not ErrHeaderNotParsed:", err)
+	}
+
 	err = p.ParseToEnd()
 	if err != dem.ErrHeaderNotParsed {
 		t.Fatal("Tried to parse tick before header but error was not ErrHeaderNotParsed:", err)

parsing.go

@@ -236,10 +236,6 @@ func (p *Parser) handleFrameParsed(*frameParsedTokenType) {
 	}()
 
 	for k, rp := range p.rawPlayers {
-		if rp == nil {
-			continue
-		}
-
 		// We need to re-map the players from their entityID to their UID.
 		// This is necessary because we don't always have the UID when the player connects (or something like that, not really sure tbh).
 		if pl := p.entityIDToPlayers[k]; pl != nil {