feat: dispatch RecordingPlayerDetecte eventd

Author: akiver

pkg/demoinfocs/events/events.go

@@ -18,6 +18,13 @@ import (
 // A frame can contain multiple ticks (usually 2 or 4) if the tv_snapshotrate differs from the tick-rate the game was played at.
 type FrameDone struct{}
 
+// RecordingPlayerDetected signals that a player started recording the demo locally.
+// If this event is dispatched, it means it's a client-side (POV) demo.
+type RecordingPlayerDetected struct {
+	PlayerSlot int
+	PlayerInfo common.PlayerInfo
+}
+
 // MatchStart signals that the match has started.
 type MatchStart struct{}
 

pkg/demoinfocs/parser.go

@@ -195,11 +195,6 @@ func (p *parser) Progress() float32 {
 	return float32(p.currentFrame) / float32(p.header.PlaybackFrames)
 }
 
-// IsPOV indicates if the demo being parsed is a POV demo.
-func (p *parser) IsPOV() bool {
-	return p.recordingPlayerSlot != -1
-}
-
 /*
 RegisterEventHandler registers a handler for game events.
 

pkg/demoinfocs/parser_interface.go

@@ -64,8 +64,6 @@ type Parser interface {
 	// Might not be 100% correct since it's just based on the reported tick count of the header.
 	// May always return 0 if the demo header is corrupt.
 	Progress() float32
-	// IsPOV indicates if the demo being parsed is a POV demo.
-	IsPOV() bool
 	/*
 	   RegisterEventHandler registers a handler for game events.
 

pkg/demoinfocs/parser_test.go

@@ -23,16 +23,6 @@ func TestParser_GameState(t *testing.T) {
 	assert.Equal(t, gs, (&parser{gameState: gs}).GameState())
 }
 
-func TestParser_IsPOV(t *testing.T) {
-	p := &parser{recordingPlayerSlot: -1}
-
-	assert.Equal(t, false, p.IsPOV())
-
-	p.recordingPlayerSlot = 3
-
-	assert.Equal(t, true, p.IsPOV())
-}
-
 func TestParser_CurrentTime(t *testing.T) {
 	p := &parser{
 		tickInterval: 2,

pkg/demoinfocs/stringtables.go

@@ -241,6 +241,7 @@ func (p *parser) processStringTable(tab *msg.CSVCMsg_CreateStringTable) {
 
 			if p.header.ClientName == player.Name {
 				p.recordingPlayerSlot = entryIndex
+				p.eventDispatcher.Dispatch(events.RecordingPlayerDetected{PlayerSlot: entryIndex, PlayerInfo: player})
 			}
 
 			p.setRawPlayer(entryIndex, player)