don't panic for unknown bombsites, raise ParserWarn event instead (#283)

Author: markus-wa

pkg/demoinfocs/events/events.go

@@ -499,9 +499,18 @@ type StringTableCreated struct {
 	TableName string
 }
 
+// WarnType identifies a kind of warning for the ParserWarn event.
+type WarnType int
+
+const (
+	WarnTypeUndefined       = iota
+	WarnTypeBombsiteUnknown // may occur on de_grind for bombsite B as the bounding box of the bombsite is wrong
+)
+
 // ParserWarn signals that a non-fatal problem occurred during parsing.
 type ParserWarn struct {
 	Message string
+	Type    WarnType
 }
 
 // GenericGameEvent signals any game-event.

pkg/demoinfocs/game_events.go

@@ -1,7 +1,6 @@
 package demoinfocs
 
 import (
-	"errors"
 	"fmt"
 
 	"github.com/golang/geo/r3"
@@ -652,7 +651,12 @@ func (geh gameEventHandler) bombEvent(data map[string]*msg.CSVCMsg_GameEventKeyT
 			bombEvent.Site = events.BombsiteB
 			geh.parser.bombsiteB.index = site
 		} else {
-			return bombEvent, errors.New("bomb not planted on bombsite A or B")
+			// this may occur on de_grind for bombsite B, really makes you think
+			// see https://github.com/markus-wa/demoinfocs-golang/issues/280
+			geh.dispatch(events.ParserWarn{
+				Message: "bombsite unknown for bomb related event",
+				Type:    events.WarnTypeBombsiteUnknown,
+			})
 		}
 	}