Warn for missing GameEventDescriptors

markus-wa · markus-wa · commit 6cf156341c65 · 2018-02-01T19:41:28.000+01:00
diff --git a/packet_handlers.go b/packet_handlers.go
@@ -87,8 +87,8 @@ func (p *Parser) handleGameEventList(gel *msg.CSVCMsg_GameEventList) {
 }
 
 func (p *Parser) handleGameEvent(ge *msg.CSVCMsg_GameEvent) {
-	// TODO: Do we really need to do this check?
 	if p.gehDescriptors == nil {
+		p.warn("Received GameEvent but event descriptors are missing")
 		return
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -87,8 +87,8 @@ func (p Parser) handleGameEventList(gel msg.CSVCMsg_GameEventList) {`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`func (p Parser) handleGameEvent(ge msg.CSVCMsg_GameEvent) {`
`90`		`- // TODO: Do we really need to do this check?`
`91`	`90`	`if p.gehDescriptors == nil {`
	`91`	`+ p.warn("Received GameEvent but event descriptors are missing")`
`92`	`92`	`return`
`93`	`93`	`}`
`94`	`94`