common: fix crash when player_connect.networkid is malformed or missing (#306)

Author: markus-wa

pkg/demoinfocs/common/common.go

@@ -2,6 +2,7 @@
 package common
 
 import (
+	"fmt"
 	"math/rand"
 	"strconv"
 	"strings"
@@ -218,6 +219,10 @@ func NewTeamState(team Team, membersCallback func(Team) []*Player) TeamState {
 func ConvertSteamIDTxtTo32(steamID string) (uint32, error) {
 	arr := strings.Split(steamID, ":")
 
+	if len(arr) != 3 {
+		return 0, fmt.Errorf("SteamID '%s' not well formed", steamID)
+	}
+
 	Y, err := strconv.ParseUint(arr[1], 10, 32)
 	if err != nil {
 		return 0, err

pkg/demoinfocs/common/common_test.go

@@ -147,6 +147,11 @@ func TestConvertSteamIDTxtTo32_Error(t *testing.T) {
 
 	assert.Equal(t, uint32(0), id)
 	assert.NotNil(t, err)
+
+	id, err = ConvertSteamIDTxtTo32("STEAM_0:b")
+
+	assert.Equal(t, uint32(0), id)
+	assert.NotNil(t, err)
 }
 
 func TestConvertSteamID32To64(t *testing.T) {

pkg/demoinfocs/game_events.go

@@ -520,11 +520,13 @@ func (geh gameEventHandler) playerConnect(data map[string]*msg.CSVCMsg_GameEvent
 		guid:   data["networkid"].GetValString(),
 	}
 
-	var err error
-	pl.xuid, err = guidToSteamID64(pl.guid)
+	if pl.guid != "" {
+		var err error
+		pl.xuid, err = guidToSteamID64(pl.guid)
 
-	if err != nil {
-		geh.parser.setError(fmt.Errorf("failed to parse player XUID: %v", err.Error()))
+		if err != nil {
+			geh.parser.setError(fmt.Errorf("failed to parse player XUID: %v", err.Error()))
+		}
 	}
 
 	geh.parser.rawPlayers[int(data["index"].GetValByte())] = pl