fix: delete disconnected players references

akiver · akiver · commit a31cefb13414 · 2025-09-04T04:16:34.000+02:00
fix akiver/cs-demo-manager#1137 fix akiver/cs-demo-manager#1192 Player controller entities may in rare occasion being re-used for new players after disconnect, leaving stale references that cause incorrect players.
diff --git a/pkg/demoinfocs/datatables.go b/pkg/demoinfocs/datatables.go
@@ -432,6 +432,8 @@ func (p *parser) bindNewPlayerController(controllerEntity st.Entity) {
 	controllerEntity.OnDestroy(func() {
 		pl.IsConnected = false
 		delete(p.gameState.playersByEntityID, controllerEntity.ID())
+		delete(p.gameState.playerControllerEntities, controllerEntity.ID())
+		delete(p.gameState.playersByUserID, pl.UserID)
 	})
 }
 

Original file line number	Diff line number	Diff line change
`@@ -432,6 +432,8 @@ func (p *parser) bindNewPlayerController(controllerEntity st.Entity) {`
`432`	`432`	`controllerEntity.OnDestroy(func() {`
`433`	`433`	`pl.IsConnected = false`
`434`	`434`	`delete(p.gameState.playersByEntityID, controllerEntity.ID())`
	`435`	`+ delete(p.gameState.playerControllerEntities, controllerEntity.ID())`
	`436`	`+ delete(p.gameState.playersByUserID, pl.UserID)`
`435`	`437`	`})`
`436`	`438`	`}`
`437`	`439`