events: delay PlayerTeamChange until end of tick

- team IDs of other players changing teams in the same tick might not have changed yet
- player entities might not have been re-created yet after a reconnect

Author: markus-wa

game_events.go

@@ -286,7 +286,7 @@ func (geh gameEventHandler) playerBlind(desc *msg.CSVCMsg_GameEventListDescripto
 
 	// Player.FlashDuration hasn't been updated yet,
 	// so we need to wait until the end of the tick before dispatching
-	geh.parser.currentFlashEvents = append(geh.parser.currentFlashEvents, events.PlayerFlashed{
+	geh.parser.delayedEvents = append(geh.parser.delayedEvents, events.PlayerFlashed{
 		Player:   geh.playerByUserID32(data["userid"].GetValShort()),
 		Attacker: geh.gameState().lastFlasher,
 	})
@@ -390,7 +390,10 @@ func (geh gameEventHandler) playerTeam(desc *msg.CSVCMsg_GameEventListDescriptor
 			player.Team = newTeam
 
 			oldTeam := common.Team(data["oldteam"].GetValByte())
-			geh.dispatch(events.PlayerTeamChange{
+			// Delayed for two reasons
+			// - team IDs of other players changing teams in the same tick might not have changed yet
+			// - player entities might not have been re-created yet after a reconnect
+			geh.parser.delayedEvents = append(geh.parser.delayedEvents, events.PlayerTeamChange{
 				Player:       player,
 				IsBot:        data["isbot"].GetValBool(),
 				Silent:       data["silent"].GetValBool(),

parser.go

@@ -10,7 +10,6 @@ import (
 
 	bit "github.com/markus-wa/demoinfocs-golang/bitread"
 	common "github.com/markus-wa/demoinfocs-golang/common"
-	events "github.com/markus-wa/demoinfocs-golang/events"
 	msg "github.com/markus-wa/demoinfocs-golang/msg"
 	st "github.com/markus-wa/demoinfocs-golang/sendtables"
 )
@@ -70,7 +69,7 @@ type Parser struct {
 	gameEventDescs       map[int32]*msg.CSVCMsg_GameEventListDescriptorT // Maps game-event IDs to descriptors
 	grenadeModelIndices  map[int]common.EquipmentElement                 // Used to map model indices to grenades (used for grenade projectiles)
 	stringTables         []*msg.CSVCMsg_CreateStringTable                // Contains all created sendtables, needed when updating them
-	currentFlashEvents   []events.PlayerFlashed                          // Contains flash events that need to be dispatched at the end of a tick
+	delayedEvents        []interface{}                                   // Contains events that need to be dispatched at the end of a tick (e.g. flash events because FlashDuration isn't updated before that)
 }
 
 type bombsite struct {

parsing.go

@@ -247,10 +247,10 @@ var frameParsedToken = new(frameParsedTokenType)
 func (p *Parser) handleFrameParsed(*frameParsedTokenType) {
 	// PlayerFlashed events need to be dispatched at the end of the tick
 	// because Player.FlashDuration is updated after the game-events are parsed.
-	for _, e := range p.currentFlashEvents {
+	for _, e := range p.delayedEvents {
 		p.eventDispatcher.Dispatch(e)
 	}
-	p.currentFlashEvents = p.currentFlashEvents[:0]
+	p.delayedEvents = p.delayedEvents[:0]
 
 	p.currentFrame++
 	p.eventDispatcher.Dispatch(events.TickDone{})