stringtables: capture player name changes and raise new PlayerNameChange event (#289)

fixes regression introduced in 0515f18 where we lost player name changes

Author: markus-wa

pkg/demoinfocs/demoinfocs_test.go

@@ -371,7 +371,7 @@ func TestDemoSet(t *testing.T) {
 						}
 
 					case events.WarnTypeTeamSwapPlayerNil:
-						t.Log("expected known issue with team swaps occurred", warn.Message)
+						t.Log("expected known issue with team swaps occurred:", warn.Message)
 						return
 
 					case events.WarnTypeGameEventBeforeDescriptors:

pkg/demoinfocs/events/events.go

@@ -417,6 +417,13 @@ type PlayerDisconnected struct {
 	Player *common.Player
 }
 
+// PlayerNameChange signals that a player's name has changed
+type PlayerNameChange struct {
+	Player  *common.Player
+	OldName string
+	NewName string
+}
+
 // SayText signals a chat message. It contains the raw
 // network message data for admin / console messages.
 // EntIdx will probably always be 0

pkg/demoinfocs/stringtables.go

@@ -53,6 +53,29 @@ func (p *parser) parseStringTables() {
 	p.bitReader.EndChunk()
 }
 
+func (p *parser) updatePlayerFromRawIfExists(index int, raw *playerInfo) {
+	pl := p.gameState.playersByEntityID[index+1]
+	if pl == nil {
+		return
+	}
+
+	oldName := pl.Name
+	newName := raw.name
+	nameChanged := !pl.IsBot && !raw.isFakePlayer && raw.guid != "BOT" && oldName != newName
+
+	pl.Name = raw.name
+	pl.SteamID64 = raw.xuid
+	pl.IsBot = raw.isFakePlayer
+
+	if nameChanged {
+		p.eventDispatcher.Dispatch(events.PlayerNameChange{
+			Player:  pl,
+			OldName: oldName,
+			NewName: newName,
+		})
+	}
+}
+
 func (p *parser) parseSingleStringTable(name string) {
 	nStrings := p.bitReader.ReadSignedInt(16)
 	for i := 0; i < nStrings; i++ {
@@ -78,6 +101,8 @@ func (p *parser) parseSingleStringTable(name string) {
 
 				p.rawPlayers[int(playerIndex)] = player
 
+				p.updatePlayerFromRawIfExists(int(playerIndex), player)
+
 			case stNameInstanceBaseline:
 				classID, err := strconv.ParseInt(stringName, 10, 64)
 				if err != nil {
@@ -217,7 +242,10 @@ func (p *parser) processStringTable(tab *msg.CSVCMsg_CreateStringTable) {
 
 		switch tab.Name {
 		case stNameUserInfo:
-			p.rawPlayers[entryIndex] = parsePlayerInfo(bytes.NewReader(userdata))
+			player := parsePlayerInfo(bytes.NewReader(userdata))
+			p.rawPlayers[entryIndex] = player
+
+			p.updatePlayerFromRawIfExists(entryIndex, player)
 
 		case stNameInstanceBaseline:
 			classID, err := strconv.ParseInt(entry, 10, 64)