Skip to content

Commit 45eb649

Browse files
authored
Fix gcu/test_portchannel_interface.py for t2 pr checker (sonic-net#21626)
Summary: Previously, this test case randomly selected DUT out of the testbed. However, if it accidentally select the supervisor as the DUT, it will skip the test case for the whole T2 testbed because the supervisor may not have portchannel config. As an improvement, I used random frontend DUT selection fixture instead. Also, we enable this for T2 PR checker. Note: this PR performed similar fixes as PR sonic-net#21666. Since PR#21666 got merged first, this PR has been repurposed to just enable the test in VS T2 PR checker. Signed-off-by: BYGX-wcr <wcr@live.cn>
1 parent 8d5a2f5 commit 45eb649

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

tests/common/plugins/conditional_mark/tests_mark_conditions_vs_t2.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -305,11 +305,6 @@ generic_config_updater/test_pg_headroom_update.py:
305305
conditions:
306306
- asic_type in ['vs'] and 't2' in topo_name
307307
reason: This test case either cannot pass or should be skipped on virtual chassis
308-
generic_config_updater/test_portchannel_interface.py:
309-
skip:
310-
conditions:
311-
- asic_type in ['vs'] and 't2' in topo_name
312-
reason: This test case either cannot pass or should be skipped on virtual chassis
313308
generic_config_updater/test_static_route.py:
314309
skip:
315310
conditions:

tests/generic_config_updater/test_portchannel_interface.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ def setup_env(duthosts, enum_rand_one_per_hwsku_frontend_hostname, portchannel_t
101101
Setup/teardown fixture for portchannel interface config
102102
Args:
103103
duthosts: list of DUTs.
104-
enum_rand_one_per_hwsku_frontend_hostname: The fixture returns one DUT per hardware SKU
104+
enum_rand_one_per_hwsku_frontend_hostname: The fixture returns a randomly selected frontend DuT per HwSKU
105105
"""
106106
duthost = duthosts[enum_rand_one_per_hwsku_frontend_hostname]
107107
create_checkpoint(duthost)

0 commit comments

Comments
 (0)