Skip to content

Commit 2a0ebe6

Browse files
authored
Merge pull request #676 from marle3003/develop
add test
2 parents 66c0049 + fea80f6 commit 2a0ebe6

File tree

3 files changed

+31
-15
lines changed

3 files changed

+31
-15
lines changed

js/typescript_test.go

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,18 @@ export default function() {
3939
err = s.Run()
4040
r.NoError(t, err)
4141

42-
time.Sleep(2 * time.Second)
4342
var calledAt time.Time
44-
err = s.RunFunc(func(vm *goja.Runtime) {
45-
v := vm.Get("calledAt")
46-
err = vm.ExportTo(v, &calledAt)
47-
r.NoError(t, err)
48-
})
49-
time.Sleep(1 * time.Second)
43+
deadline := time.Now().Add(5 * time.Second)
44+
for time.Now().Before(deadline) {
45+
_ = s.RunFunc(func(vm *goja.Runtime) {
46+
v := vm.Get("calledAt")
47+
_ = vm.ExportTo(v, &calledAt)
48+
})
49+
if !calledAt.IsZero() {
50+
break
51+
}
52+
time.Sleep(100 * time.Millisecond)
53+
}
5054
r.False(t, calledAt.IsZero(), "calledAt should not be zero")
5155
r.Greater(t, calledAt.Sub(startTime), time.Second, "code should wait for a second")
5256
},

try/net.go

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,9 @@ import (
66
)
77

88
func GetFreePort() int {
9-
addr, err := net.ResolveTCPAddr("tcp", "localhost:")
10-
if err != nil {
11-
panic(err)
12-
}
9+
addr, _ := net.ResolveTCPAddr("tcp", "localhost:")
1310

14-
l, err := net.ListenTCP("tcp", addr)
15-
if err != nil {
16-
panic(err)
17-
}
11+
l, _ := net.ListenTCP("tcp", addr)
1812
defer func() { _ = l.Close() }()
1913
return l.Addr().(*net.TCPAddr).Port
2014
}

try/net_test.go

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
package try
2+
3+
import (
4+
"github.com/stretchr/testify/require"
5+
"testing"
6+
)
7+
8+
func TestGetFreePort(t *testing.T) {
9+
port := GetFreePort()
10+
require.Greater(t, port, 0)
11+
}
12+
13+
func TestMustUrl(t *testing.T) {
14+
u := MustUrl("http://localhost")
15+
require.NotNil(t, u)
16+
17+
require.Panics(t, func() { MustUrl(":") })
18+
}

0 commit comments

Comments
 (0)