Semicolon shows up when autocompleting from history using up arrow

[Aspecky]

Environment

% typeset -p1 VENDOR OSTYPE ZSH_PATCHLEVEL _autocomplete__funcfiletrace
typeset VENDOR=apple
typeset OSTYPE=darwin19.0
typeset ZSH_PATCHLEVEL=zsh-5.7.1-0-g8b89d0d
typeset -a _autocomplete__funcfiletrace=(
  /Users/aspecky/opt/homebrew/share/zsh-autocomplete/zsh-autocomplete.plugin.zsh:4
  .zshrc:109
  zsh:6
)
% git -C ~autocomplete log --oneline -n1
999134536e Merge pull request #20813 from Homebrew/cask/audit-only-use-sparkle_min_os-as-fallback

• Operating system: macOS Catalina 10.15.7
• Terminal emulator: iTerm

Steps to reproduce

% ls
zsh-autocomplete	zshrc
% ls # press up arrow
% ls; # adds semicolon

The issue is similar to #361, #141 and #297 that are all closed.

[Kas-tle]

I noticed in the README it states this can be disabled with the zstyle append-semicolon no:

zsh-autocomplete/README.md

Lines 255 to 260 in bbba73e

	### Don't add a semicolon after history completions
	By default, Autocomplete adds a semicolon to each history line to allow adding another line with
	<kbd>Ctrl</kbd><kbd>Space</kbd>. You can deactivate this feature as follows:
	```zsh
	zstyle ':autocomplete:*' append-semicolon no
	```

However, the plugin seems to actually check for add-semicolon:

zsh-autocomplete/Completions/_autocomplete__history_lines

Lines 137 to 141 in bbba73e

	local -Pa suf=( -S '' )
	if [[ $WIDGETSTYLE == *-select* && $#matches[@] > 1 ]] &&
	zstyle -T ":autocomplete:${curcontext}:history-lines" add-semicolon; then
	suf=( -S ';' -R _autocomplete__history_lines_suffix )
	fi

If I add to my ~/.zshrc on the latest version of the plugin, I don't get semicolons on up arrow anymore:

zstyle ':autocomplete:*' add-semicolon no

[ashwinuae]

zstyle ':autocomplete:*' add-semicolon no

@Kas-tle Yes that worked for me, thank you!

[Aspecky]

Nice catch @Kas-tle , but zstyle ':autocomplete:*' add-semicolon no is not working for me, do you have ohmyzsh installed? I made sure that I am on the latest update of zsh-autocomplete and to add the zstyle before sourcing the script. I tried on both arch and macOS to no avail. Although I still think it would be good to make a PR to correct the add-semicolon in the README

[ashwinuae]

@Aspecky Hmm that's strange, I have zsh-autocomplete registered as a plugin with ohmyzsh. Seeing @Kas-tle's comment, all I did was add that line to my ~/.zshrc , pull the repo at $ZSH_CUSTOM/plugins/zsh-autocomplete to the latest, then issue a omz reload and the semicolons disappeared. This was in Ubuntu 22.04 if that helps.

[Kas-tle]

@Aspecky yeah I use oh-my-zsh as well. I think the setting was added in the last week, so you may have to go into the git repo where this plugin is stored and git fetch/pull the latest changes.

[Aspecky]

@Kas-tle Thanks, I pulled the repo and it now works properly, it seems like they have not released that update yet, it's only available in the github repo and not their releases.