code review applied

Author: ThieryMichel

docs/ShowBase.md

@@ -63,7 +63,7 @@ const App = () => (
 | Prop             | Required | Type              | Default | Description
 |------------------|----------|-------------------|---------|--------------------------------------------------------
 | `children`       | Optional | `ReactNode`       |         | The components rendering the record fields
-| `children`       | Optional | `(props: ShowControllerResult<RecordType>) => ReactNode`       |         | Alternative to children, a function that takes the ShowController context and renders the form
+| `render`       | Optional | `(props: ShowControllerResult<RecordType>) => ReactNode`       |         | Alternative to children, a function that takes the ShowController context and renders the form
 | `disable Authentication` | Optional | `boolean` |         | Set to `true` to disable the authentication check
 | `empty WhileLoading` | Optional | `boolean`     |         | Set to `true` to return `null` while the list is loading
 | `id`             | Optional | `string`          |         | The record identifier. If not provided, it will be deduced from the URL

packages/ra-core/src/controller/create/CreateBase.stories.tsx

@@ -151,7 +151,6 @@ export const AccessControl = ({
 export const WithRenderProp = ({
     dataProvider = defaultDataProvider,
     callTimeOptions,
-    ...props
 }: {
     dataProvider?: DataProvider;
     callTimeOptions?: SaveHandlerCallbacks;

packages/ra-core/src/controller/list/ListBase.stories.tsx

@@ -296,19 +296,11 @@ export const WithRenderProps = ({
                     data,
                     error,
                     isPending,
-                    sort,
-                    filterValues,
                     page,
                     perPage,
                     setPage,
                     total,
                 } = controllerProps;
-                const defaultValue = JSON.stringify({
-                    page,
-                    perPage,
-                    sort,
-                    filterValues,
-                });
                 if (isPending) {
                     return <div>Loading...</div>;
                 }

packages/ra-ui-materialui/src/list/List.tsx

@@ -99,7 +99,7 @@ export const List = <RecordType extends RaRecord = any>(
 };
 
 export interface ListProps<RecordType extends RaRecord = any>
-    extends ListBaseProps<RecordType>,
+    extends Omit<ListBaseProps<RecordType>, 'children'>,
         ListViewProps {}
 
 const defaultFilter = {};

packages/ra-ui-materialui/src/list/ListView.tsx

@@ -191,7 +191,7 @@ export interface ListViewProps {
      *     </List>
      * );
      */
-    children?: ReactNode;
+    children: ReactNode;
 
     /**
      * The component used to display the list. Defaults to <Card>.