Review

Author: fzaninotto

docs/InPlaceEditor.md

@@ -24,6 +24,7 @@ Use `<InPlaceEditor>` inside a `RecordContext` (e.g., under `<List>` or `<Show>`
 ```tsx
 import { Show, InPlaceEditor } from 'react-admin';
 import { Stack, Box, Typography } from '@mui/material';
+import { AvatarField, CustomerActions } from './components';
 
 const CustomerShow = () => (
     <Show>
@@ -65,7 +66,6 @@ const choices = [
 
 // ...
 <InPlaceEditor
-    source="access"
     editor={
         <SelectInput
             source="access"
@@ -169,7 +169,6 @@ For example, to use a `<SelectInput>` in edit mode, you can use the following co
 {% raw %}
 ```tsx
 <InPlaceEditor
-    source="access"
     editor={
         <SelectInput
             source="access"

packages/ra-ui-materialui/src/input/InPlaceEditor/InPlaceEditor.Card.stories.tsx

@@ -25,6 +25,7 @@ import {
     TestMemoryRouter,
     NotificationContextProvider,
     UndoableMutationsContextProvider,
+    required,
 } from 'ra-core';
 import fakeRestDataProvider from 'ra-data-fakerest';
 import polyglotI18nProvider from 'ra-i18n-polyglot';
@@ -336,6 +337,7 @@ export const Complex = () => {
                                         helperText={false}
                                         autoFocus
                                         SelectProps={{ defaultOpen: true }}
+                                        validate={required()}
                                         sx={{
                                             '& .MuiInput-root': {
                                                 marginTop: 0,

packages/ra-ui-materialui/src/input/InPlaceEditor/InPlaceEditor.stories.tsx

@@ -11,6 +11,7 @@ import {
     TestMemoryRouter,
     NotificationContextProvider,
     UndoableMutationsContextProvider,
+    required,
 } from 'ra-core';
 import fakeRestDataProvider from 'ra-data-fakerest';
 import polyglotI18nProvider from 'ra-i18n-polyglot';
@@ -219,7 +220,7 @@ export const SX = () => (
     </Wrapper>
 );
 
-export const EditbleDataTable = () => (
+export const EditableDataTable = () => (
     <TestMemoryRouter>
         <QueryClientProvider client={new QueryClient()}>
             <DataProviderContext.Provider
@@ -325,6 +326,7 @@ export const EditbleDataTable = () => (
                                                             margin="none"
                                                             label={false}
                                                             variant="standard"
+                                                            validate={required()}
                                                             autoFocus
                                                             SelectProps={{
                                                                 defaultOpen:

packages/ra-ui-materialui/src/input/InPlaceEditor/InPlaceEditor.tsx

@@ -82,6 +82,11 @@ export const InPlaceEditor = (props: InPlaceEditorProps) => {
             'InPlaceEditor requires either a source prop or children or editor prop'
         );
     }
+    if (mutationMode === 'undoable' && !notifyOnSuccess) {
+        throw new Error(
+            'InPlaceEditor requires notifyOnSuccess to be true when mutationMode is undoable'
+        );
+    }
 
     const submitButtonRef = useRef<HTMLButtonElement>(null);