Skip to content

Commit 2797c03

Browse files
djhidjhi
committed
Remove logs from useDelete stories and tests
1 parent f58fbbc commit 2797c03

File tree

5 files changed

+18
-45
lines changed

5 files changed

+18
-45
lines changed

‎packages/ra-core/src/dataProvider/useDelete.optimistic.stories.tsx‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,13 @@ export const SuccessCase = () => {
1414
{ id: 2, title: 'World' },
1515
];
1616
const dataProvider = {
17-
getList: (resource, params) => {
18-
console.log('getList', resource, params);
17+
getList: () => {
1918
return Promise.resolve({
2019
data: posts,
2120
total: posts.length,
2221
});
2322
},
24-
delete: (resource, params) => {
25-
console.log('delete', resource, params);
23+
delete: (_, params) => {
2624
return new Promise(resolve => {
2725
setTimeout(() => {
2826
const index = posts.findIndex(p => p.id === params.id);
@@ -82,15 +80,13 @@ export const ErrorCase = () => {
8280
{ id: 2, title: 'World' },
8381
];
8482
const dataProvider = {
85-
getList: (resource, params) => {
86-
console.log('getList', resource, params);
83+
getList: () => {
8784
return Promise.resolve({
8885
data: posts,
8986
total: posts.length,
9087
});
9188
},
92-
delete: (resource, params) => {
93-
console.log('delete', resource, params);
89+
delete: () => {
9490
return new Promise((resolve, reject) => {
9591
setTimeout(() => {
9692
reject(new Error('something went wrong'));

‎packages/ra-core/src/dataProvider/useDelete.pessimistic.stories.tsx‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,13 @@ export const SuccessCase = () => {
1616
{ id: 2, title: 'World' },
1717
];
1818
const dataProvider = {
19-
getList: (resource, params) => {
20-
console.log('getList', resource, params);
19+
getList: () => {
2120
return Promise.resolve({
2221
data: posts,
2322
total: posts.length,
2423
});
2524
},
26-
delete: (resource, params) => {
27-
console.log('delete', resource, params);
25+
delete: (_, params) => {
2826
return new Promise(resolve => {
2927
setTimeout(() => {
3028
const index = posts.findIndex(p => p.id === params.id);
@@ -181,15 +179,13 @@ export const ErrorCase = () => {
181179
{ id: 2, title: 'World' },
182180
];
183181
const dataProvider = {
184-
getList: (resource, params) => {
185-
console.log('getList', resource, params);
182+
getList: () => {
186183
return Promise.resolve({
187184
data: posts,
188185
total: posts.length,
189186
});
190187
},
191-
delete: (resource, params) => {
192-
console.log('delete', resource, params);
188+
delete: () => {
193189
return new Promise((resolve, reject) => {
194190
setTimeout(() => {
195191
reject(new Error('something went wrong'));

‎packages/ra-core/src/dataProvider/useDelete.spec.tsx‎

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ describe('useDelete', () => {
7777
});
7878

7979
it('uses the latest declaration time mutationMode', async () => {
80-
jest.spyOn(console, 'log').mockImplementation(() => {});
8180
// This story uses the pessimistic mode by default
8281
render(<MutationMode />);
8382
await waitFor(() => new Promise(resolve => setTimeout(resolve, 0)));
@@ -99,21 +98,18 @@ describe('useDelete', () => {
9998
});
10099

101100
it('uses the latest declaration time params', async () => {
102-
jest.spyOn(console, 'log').mockImplementation(() => {});
103101
const posts = [
104102
{ id: 1, title: 'Hello' },
105103
{ id: 2, title: 'World' },
106104
];
107105
const dataProvider = {
108-
getList: (resource, params) => {
109-
console.log('getList', resource, params);
106+
getList: () => {
110107
return Promise.resolve({
111108
data: posts,
112109
total: posts.length,
113110
});
114111
},
115-
delete: jest.fn((resource, params) => {
116-
console.log('delete', resource, params);
112+
delete: jest.fn((_, params) => {
117113
return new Promise(resolve => {
118114
setTimeout(() => {
119115
const index = posts.findIndex(p => p.id === params.id);
@@ -384,7 +380,6 @@ describe('useDelete', () => {
384380

385381
describe('mutationMode', () => {
386382
it('when pessimistic, displays result and success side effects when dataProvider promise resolves', async () => {
387-
jest.spyOn(console, 'log').mockImplementation(() => {});
388383
render(<SuccessCasePessimistic />);
389384
screen.getByText('Delete first post').click();
390385
await waitFor(() => {
@@ -401,7 +396,6 @@ describe('useDelete', () => {
401396
expect(screen.queryByText('World')).not.toBeNull();
402397
});
403398
it('when pessimistic, displays error and error side effects when dataProvider promise rejects', async () => {
404-
jest.spyOn(console, 'log').mockImplementation(() => {});
405399
jest.spyOn(console, 'error').mockImplementation(() => {});
406400
render(<ErrorCasePessimistic />);
407401
screen.getByText('Delete first post').click();
@@ -450,7 +444,6 @@ describe('useDelete', () => {
450444
).not.toBeNull();
451445
});
452446
it('when optimistic, displays result and success side effects right away', async () => {
453-
jest.spyOn(console, 'log').mockImplementation(() => {});
454447
render(<SuccessCaseOptimistic />);
455448
await waitFor(() => new Promise(resolve => setTimeout(resolve, 0)));
456449
screen.getByText('Delete first post').click();
@@ -468,7 +461,6 @@ describe('useDelete', () => {
468461
});
469462
});
470463
it('when optimistic, displays error and error side effects when dataProvider promise rejects', async () => {
471-
jest.spyOn(console, 'log').mockImplementation(() => {});
472464
jest.spyOn(console, 'error').mockImplementation(() => {});
473465
render(<ErrorCaseOptimistic />);
474466
await waitFor(() => new Promise(resolve => setTimeout(resolve, 0)));
@@ -490,7 +482,6 @@ describe('useDelete', () => {
490482
});
491483
});
492484
it('when undoable, displays result and success side effects right away and fetched on confirm', async () => {
493-
jest.spyOn(console, 'log').mockImplementation(() => {});
494485
render(<SuccessCaseUndoable />);
495486
await waitFor(() => new Promise(resolve => setTimeout(resolve, 0)));
496487
screen.getByText('Delete first post').click();
@@ -518,7 +509,6 @@ describe('useDelete', () => {
518509
);
519510
});
520511
it('when undoable, displays result and success side effects right away and reverts on cancel', async () => {
521-
jest.spyOn(console, 'log').mockImplementation(() => {});
522512
render(<SuccessCaseUndoable />);
523513
await waitFor(() => new Promise(resolve => setTimeout(resolve, 0)));
524514
screen.getByText('Delete first post').click();
@@ -536,7 +526,6 @@ describe('useDelete', () => {
536526
});
537527
});
538528
it('when undoable, displays result and success side effects right away and reverts on error', async () => {
539-
jest.spyOn(console, 'log').mockImplementation(() => {});
540529
jest.spyOn(console, 'error').mockImplementation(() => {});
541530
render(<ErrorCaseUndoable />);
542531
await waitFor(() => new Promise(resolve => setTimeout(resolve, 0)));

‎packages/ra-core/src/dataProvider/useDelete.stories.tsx‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,13 @@ export const MutationMode = () => {
1515
{ id: 2, title: 'World' },
1616
];
1717
const dataProvider = {
18-
getList: (resource, params) => {
19-
console.log('getList', resource, params);
18+
getList: () => {
2019
return Promise.resolve({
2120
data: posts,
2221
total: posts.length,
2322
});
2423
},
25-
delete: (resource, params) => {
26-
console.log('delete', resource, params);
24+
delete: (_, params) => {
2725
return new Promise(resolve => {
2826
setTimeout(() => {
2927
const index = posts.findIndex(p => p.id === params.id);
@@ -94,15 +92,13 @@ export const Params = ({ dataProvider }: { dataProvider?: DataProvider }) => {
9492
{ id: 2, title: 'World' },
9593
];
9694
const defaultDataProvider = {
97-
getList: (resource, params) => {
98-
console.log('getList', resource, params);
95+
getList: () => {
9996
return Promise.resolve({
10097
data: posts,
10198
total: posts.length,
10299
});
103100
},
104-
delete: (resource, params) => {
105-
console.log('delete', resource, params);
101+
delete: (_, params) => {
106102
return new Promise(resolve => {
107103
setTimeout(() => {
108104
const index = posts.findIndex(p => p.id === params.id);

‎packages/ra-core/src/dataProvider/useDelete.undoable.stories.tsx‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,13 @@ export const SuccessCase = () => {
1515
{ id: 2, title: 'World' },
1616
];
1717
const dataProvider = {
18-
getList: (resource, params) => {
19-
console.log('getList', resource, params);
18+
getList: () => {
2019
return Promise.resolve({
2120
data: posts,
2221
total: posts.length,
2322
});
2423
},
25-
delete: (resource, params) => {
26-
console.log('delete', resource, params);
24+
delete: (_, params) => {
2725
return new Promise(resolve => {
2826
setTimeout(() => {
2927
const index = posts.findIndex(p => p.id === params.id);
@@ -112,15 +110,13 @@ export const ErrorCase = () => {
112110
{ id: 2, title: 'World' },
113111
];
114112
const dataProvider = {
115-
getList: (resource, params) => {
116-
console.log('getList', resource, params);
113+
getList: () => {
117114
return Promise.resolve({
118115
data: posts,
119116
total: posts.length,
120117
});
121118
},
122-
delete: (resource, params) => {
123-
console.log('delete', resource, params);
119+
delete: () => {
124120
return new Promise((resolve, reject) => {
125121
setTimeout(() => {
126122
reject(new Error('something went wrong'));

0 commit comments

Comments
 (0)