Improve side effects handling depending on the mutationMode

Author: djhi

packages/ra-ui-materialui/src/button/BulkUpdateWithConfirmButton.tsx

@@ -44,19 +44,40 @@ export const BulkUpdateWithConfirmButton = (
     const { handleUpdate, isPending } = useBulkUpdateController({
         ...rest,
         mutationMode,
+        mutationOptions: {
+            ...rest.mutationOptions,
+            onSettled(data, error, variables, context) {
+                // In pessimistic mode, we wait for the mutation to be completed (either successfully or with an error) before closing
+                if (mutationMode === 'pessimistic') {
+                    setOpen(false);
+                }
+                rest.mutationOptions?.onSettled?.(
+                    data,
+                    error,
+                    variables,
+                    context
+                );
+            },
+        },
     });
 
-    const handleClick = e => {
-        setOpen(true);
+    const handleClick = (e: React.MouseEvent<HTMLButtonElement>) => {
         e.stopPropagation();
+        setOpen(true);
     };
 
-    const handleDialogClose = () => {
+    const handleDialogClose = (e: React.MouseEvent) => {
+        e.stopPropagation();
         setOpen(false);
     };
 
-    const handleConfirm = e => {
-        setOpen(false);
+    const handleConfirm = (e: React.MouseEvent<HTMLButtonElement>) => {
+        e.stopPropagation();
+        // We close the dialog immediately here for optimistic/undoable modes instead of in onSuccess/onError
+        // to avoid reimplementing the default side effects
+        if (mutationMode !== 'pessimistic') {
+            setOpen(false);
+        }
         handleUpdate(data);
 
         if (typeof onClick === 'function') {