Skip to content

Commit 490fd39

Browse files
committed
Fix ReferenceField regression
1 parent f705071 commit 490fd39

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

packages/ra-core/src/controller/field/ReferenceFieldBase.spec.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,6 @@ import { ReferenceFieldBase } from './ReferenceFieldBase';
88
import { Error, Loading, Meta } from './ReferenceFieldBase.stories';
99

1010
describe('<ReferenceFieldBase />', () => {
11-
const defaultProps = {
12-
reference: 'posts',
13-
resource: 'comments',
14-
source: 'post_id',
15-
};
16-
1711
beforeAll(() => {
1812
window.scrollTo = jest.fn();
1913
});
@@ -52,7 +46,7 @@ describe('<ReferenceFieldBase />', () => {
5246
});
5347
render(
5448
<CoreAdminContext dataProvider={dataProvider}>
55-
<ReferenceFieldBase {...defaultProps}>
49+
<ReferenceFieldBase reference="posts" source="post_id">
5650
<MyComponent />
5751
</ReferenceFieldBase>
5852
</CoreAdminContext>

packages/ra-core/src/controller/field/ReferenceFieldBase.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,9 @@ export const ReferenceFieldBase = <
5050
useReferenceFieldController<ReferenceRecordType>(props);
5151

5252
if (
53-
// no foreign key value
54-
!id ||
53+
(empty &&
54+
// no foreign key value
55+
!id) ||
5556
// no reference record
5657
(!controllerProps.error &&
5758
!controllerProps.isPending &&

0 commit comments

Comments
 (0)