Skip to content

Commit 8ced661

Browse files
committed
Improve code
1 parent 6dd1bcb commit 8ced661

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

packages/ra-ui-materialui/src/list/datagrid/DatagridHeader.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,8 @@ export const DatagridHeader = (props: DatagridHeaderProps) => {
5858
event.target.checked
5959
? selectedIds.concat(
6060
data
61-
.filter(
62-
record => !selectedIds.includes(record.id)
63-
)
6461
.filter(record =>
62+
!selectedIds.includes(record.id) &&
6563
isRowSelectable
6664
? isRowSelectable(record)
6765
: true
@@ -70,7 +68,7 @@ export const DatagridHeader = (props: DatagridHeaderProps) => {
7068
)
7169
: // We should only unselect the ids present in the current page
7270
selectedIds.filter(
73-
id => !data.map(record => record.id).includes(id)
71+
id => !data.some(record => record.id === id)
7472
)
7573
);
7674
},

packages/ra-ui-materialui/src/list/datatable/SelectPageCheckbox.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,8 @@ export const SelectPageCheckbox = () => {
2222
event.target.checked
2323
? selectedIds.concat(
2424
data
25-
.filter(
26-
record => !selectedIds.includes(record.id)
27-
)
2825
.filter(record =>
26+
!selectedIds.includes(record.id) &&
2927
isRowSelectable
3028
? isRowSelectable(record)
3129
: true
@@ -34,7 +32,7 @@ export const SelectPageCheckbox = () => {
3432
)
3533
: // We should only unselect the ids present in the current page
3634
selectedIds.filter(
37-
id => !data.map(record => record.id).includes(id)
35+
id => !data.some(record => record.id === id)
3836
)
3937
);
4038
},

0 commit comments

Comments
 (0)