Skip to content

Commit 8f9bdcd

Browse files
authored
Merge pull request #10954 from marmelab/doc-fix-selectAllButton
[Doc] Fix `<BulkActionsToolbar selectAllButton>` only accepts an element
2 parents 21d5221 + 984f19b commit 8f9bdcd

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

docs/Buttons.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1405,7 +1405,7 @@ export const PostList = () => (
14051405
<List>
14061406
<DataTable
14071407
bulkActionsToolbar={
1408-
<BulkActionsToolbar selectAllButton={PostSelectAllButton}>
1408+
<BulkActionsToolbar selectAllButton={<PostSelectAllButton />}>
14091409
<BulkDeleteButton />
14101410
</BulkActionsToolbar>
14111411
}

packages/ra-ui-materialui/src/button/SelectAllButton.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ import { Button, type ButtonProps } from './Button';
4141
* <List>
4242
* <Datagrid
4343
* bulkActionsToolbar={
44-
* <BulkActionsToolbar selectAllButton={PostSelectAllButton}>
44+
* <BulkActionsToolbar selectAllButton={<PostSelectAllButton />}>
4545
* <BulkDeleteButton />
4646
* </BulkActionsToolbar>
4747
* }

packages/ra-ui-materialui/src/list/BulkActionsToolbar.tsx

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
11
import * as React from 'react';
2-
import {
3-
isValidElement,
4-
type ReactElement,
5-
type ReactNode,
6-
useCallback,
7-
} from 'react';
2+
import { isValidElement, type ReactNode, useCallback } from 'react';
83
import {
94
type ComponentsOverrides,
105
styled,
@@ -95,7 +90,7 @@ export interface BulkActionsToolbarProps {
9590
children?: ReactNode;
9691
label?: string;
9792
className?: string;
98-
selectAllButton?: ReactElement | false;
93+
selectAllButton?: ReactNode;
9994
}
10095

10196
const PREFIX = 'RaBulkActionsToolbar';

0 commit comments

Comments
 (0)