Merge pull request #11040 from marmelab/fix-save-button-story

[chore] Fix `<SaveButton>` _Dirty_ story

Author: fzaninotto

packages/ra-ui-materialui/src/button/SaveButton.spec.tsx

@@ -23,6 +23,7 @@ import { AdminContext } from '../AdminContext';
 import {
     AlwaysEnable,
     Basic,
+    Dirty,
     ComplexForm,
     EnabledWhenFormIsPrefilled,
 } from './SaveButton.stories';
@@ -69,6 +70,15 @@ describe('<SaveButton />', () => {
         );
     });
 
+    it('should render an enabled button when the form is dirty', async () => {
+        render(<Dirty />);
+        await waitFor(() =>
+            expect(screen.getByLabelText('ra.action.save')['disabled']).toEqual(
+                false
+            )
+        );
+    });
+
     it('should render as submit type by default', async () => {
         render(<Basic />);
         await waitFor(() =>

packages/ra-ui-materialui/src/button/SaveButton.stories.tsx

@@ -26,10 +26,14 @@ export const Basic = () => (
 );
 
 const MakeFormChange = () => {
-    const { setValue } = useFormContext();
+    const {
+        setValue,
+        formState: { isReady },
+    } = useFormContext();
     React.useEffect(() => {
+        if (!isReady) return;
         setValue('name', 'test', { shouldDirty: true });
-    }, [setValue]);
+    }, [isReady, setValue]);
     return null;
 };