Avoid breaking change for middlewares

Author: djhi

packages/ra-core/src/dataProvider/useCreate.ts

@@ -12,6 +12,7 @@ import type {
     Identifier,
     DataProvider,
     MutationMode,
+    CreateResult,
 } from '../types';
 import { useEvent } from '../util';
 import {
@@ -96,17 +97,15 @@ export const useCreate = <
     } = options;
 
     const dataProviderCreate = useEvent((resource: string, params) =>
-        dataProvider
-            .create<
-                RecordType,
-                ResultRecordType
-            >(resource, params as CreateParams<RecordType>)
-            .then(({ data }) => data)
+        dataProvider.create<RecordType, ResultRecordType>(
+            resource,
+            params as CreateParams<RecordType>
+        )
     );
 
     const [mutate, mutationResult] = useMutationWithMutationMode<
         MutationError,
-        ResultRecordType,
+        CreateResult<ResultRecordType>,
         UseCreateMutateParams<RecordType>
     >(
         { resource, ...params },
@@ -135,7 +134,9 @@ export const useCreate = <
                         ? result?.id
                         : params.data?.id;
                 if (!id) {
-                    return undefined;
+                    throw new Error(
+                        'Invalid dataProvider response for create: missing id'
+                    );
                 }
                 // hack: only way to tell react-query not to fetch this query for the next 5 seconds
                 // because setQueryData doesn't accept a stale time option

packages/ra-core/src/dataProvider/useDelete.ts

@@ -14,6 +14,7 @@ import type {
     MutationMode,
     GetListResult as OriginalGetListResult,
     GetInfiniteListResult,
+    DeleteResult,
 } from '../types';
 import {
     type Snapshot,
@@ -93,7 +94,7 @@ export const useDelete = <
 
     const [mutate, mutationResult] = useMutationWithMutationMode<
         MutationError,
-        RecordType | undefined,
+        DeleteResult<RecordType>,
         UseDeleteMutateParams<RecordType>
     >(
         { resource, ...params },
@@ -110,12 +111,10 @@ export const useDelete = <
                         'useDelete mutation requires a non-empty id'
                     );
                 }
-                return dataProvider
-                    .delete<RecordType>(
-                        resource,
-                        params as DeleteParams<RecordType>
-                    )
-                    .then(({ data }) => data);
+                return dataProvider.delete<RecordType>(
+                    resource,
+                    params as DeleteParams<RecordType>
+                );
             },
             updateCache: ({ resource, ...params }, { mutationMode }) => {
                 // hack: only way to tell react-query not to fetch this query for the next 5 seconds

packages/ra-core/src/dataProvider/useDeleteMany.ts

@@ -14,6 +14,7 @@ import type {
     MutationMode,
     GetListResult as OriginalGetListResult,
     GetInfiniteListResult,
+    DeleteManyResult,
 } from '../types';
 import { useEvent } from '../util';
 import {
@@ -93,7 +94,7 @@ export const useDeleteMany = <
 
     const [mutate, mutationResult] = useMutationWithMutationMode<
         MutationError,
-        Array<RecordType['id']> | undefined,
+        DeleteManyResult<RecordType>,
         UseDeleteManyMutateParams<RecordType>
     >(
         { resource, ...params },
@@ -112,12 +113,10 @@ export const useDeleteMany = <
                         'useDeleteMany mutation requires an array of ids'
                     );
                 }
-                return dataProvider
-                    .deleteMany<RecordType>(
-                        resource,
-                        params as DeleteManyParams<RecordType>
-                    )
-                    .then(({ data }) => data);
+                return dataProvider.deleteMany<RecordType>(
+                    resource,
+                    params as DeleteManyParams<RecordType>
+                );
             },
             updateCache: ({ resource, ...params }, { mutationMode }) => {
                 // hack: only way to tell react-query not to fetch this query for the next 5 seconds