Skip to content

Commit a5c0799

Browse files
committed
Fix runtime checks error messages
1 parent 3b462d7 commit a5c0799

File tree

5 files changed

+26
-10
lines changed

5 files changed

+26
-10
lines changed

packages/ra-core/src/dataProvider/useCreate.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,10 @@ export const useCreate = <
118118
if (resource == null) {
119119
throw new Error('useCreate mutation requires a resource');
120120
}
121-
if (params == null) {
122-
throw new Error('useCreate mutation requires parameters');
121+
if (params.data == null) {
122+
throw new Error(
123+
'useCreate mutation requires a non-empty data object'
124+
);
123125
}
124126
return dataProviderCreate(resource, params);
125127
},

packages/ra-core/src/dataProvider/useDelete.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,10 @@ export const useDelete = <
105105
if (resource == null) {
106106
throw new Error('useDelete mutation requires a resource');
107107
}
108-
if (params == null) {
109-
throw new Error('useDelete mutation requires parameters');
108+
if (params.id == null) {
109+
throw new Error(
110+
'useDelete mutation requires a non-empty id'
111+
);
110112
}
111113
return dataProvider
112114
.delete<RecordType>(

packages/ra-core/src/dataProvider/useDeleteMany.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,9 @@ export const useDeleteMany = <
107107
'useDeleteMany mutation requires a resource'
108108
);
109109
}
110-
if (params == null) {
110+
if (params.ids == null) {
111111
throw new Error(
112-
'useDeleteMany mutation requires parameters'
112+
'useDeleteMany mutation requires an array of ids'
113113
);
114114
}
115115
return dataProvider

packages/ra-core/src/dataProvider/useUpdate.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,15 @@ export const useUpdate = <RecordType extends RaRecord = any, ErrorType = Error>(
118118
if (resource == null) {
119119
throw new Error('useUpdate mutation requires a resource');
120120
}
121-
if (params == null) {
122-
throw new Error('useUpdate mutation requires parameters');
121+
if (params.id == null) {
122+
throw new Error(
123+
'useUpdate mutation requires a non-empty id'
124+
);
125+
}
126+
if (!params.data) {
127+
throw new Error(
128+
'useUpdate mutation requires a non-empty data object'
129+
);
123130
}
124131
return dataProviderUpdate(
125132
resource,

packages/ra-core/src/dataProvider/useUpdateMany.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,9 +117,14 @@ export const useUpdateMany = <
117117
'useUpdateMany mutation requires a resource'
118118
);
119119
}
120-
if (params == null) {
120+
if (params.ids == null) {
121121
throw new Error(
122-
'useUpdateMany mutation requires parameters'
122+
'useUpdateMany mutation requires an array of ids'
123+
);
124+
}
125+
if (!params.data) {
126+
throw new Error(
127+
'useUpdateMany mutation requires a non-empty data object'
123128
);
124129
}
125130
return dataProviderUpdateMany(

0 commit comments

Comments
 (0)