Apply review suggestions

Author: djhi

packages/ra-core/src/controller/input/ReferenceInputBase.tsx

@@ -83,7 +83,8 @@ export const ReferenceInputBase = (props: ReferenceInputBaseProps) => {
 
     const shouldRenderOffline =
         isPaused &&
-        allChoices == null &&
+        // TODO v6: we can't rely on isPlaceHolderData here because useReferenceInputController always return at least an empty array
+        allChoices?.length === 0 &&
         offline !== false &&
         offline !== undefined;
 

packages/ra-core/src/controller/input/useReferenceInputController.ts

@@ -197,8 +197,11 @@ export const useReferenceInputController = <RecordType extends RaRecord = any>(
         () =>
             ({
                 sort: currentSort,
-                allChoices: finalData,
-                availableChoices: possibleValuesData,
+                // TODO v6: we shouldn't return a default empty array. This is actually enforced at the type level in other hooks such as useListController
+                allChoices: finalData ?? [],
+                // TODO v6: same as above
+                availableChoices: possibleValuesData ?? [],
+                // TODO v6: same as above
                 selectedChoices: referenceRecord ? [referenceRecord] : [],
                 displayedFilters: params.displayedFilters,
                 error: errorReference || errorPossibleValues,

packages/ra-core/src/form/choices/useChoicesContext.ts

@@ -41,9 +41,11 @@ export const useChoicesContext = <ChoicesType extends RaRecord = RaRecord>(
                 hasPreviousPage:
                     options.hasPreviousPage ?? list.hasPreviousPage,
                 hideFilter: options.hideFilter ?? list.hideFilter,
+                isFetching: list.isFetching ?? false, // same
                 isLoading: list.isLoading ?? false, // we must take the one for useList, otherwise the loading state isn't synchronized with the data
+                isPaused: list.isPaused ?? false, // same
                 isPending: list.isPending ?? false, // same
-                isFetching: list.isFetching ?? false, // same
+                isPlaceholderData: list.isPlaceholderData ?? false, // same
                 page: options.page ?? list.page,
                 perPage: options.perPage ?? list.perPage,
                 refetch: options.refetch ?? list.refetch,

packages/ra-ui-materialui/src/input/AutocompleteInput.tsx

@@ -626,6 +626,23 @@ If you provided a React element for the optionText prop, you must also provide t
     const renderHelperText = !!fetchError || helperText !== false || invalid;
 
     const handleInputRef = useForkRef(field.ref, TextFieldProps?.inputRef);
+    // When there is no network connectivity and we weren't even able to load the current value
+    if (
+        isPaused &&
+        offline !== false &&
+        offline !== undefined &&
+        ((field.value != null && selectedChoice == null) ||
+            suggestions.length === 0)
+    ) {
+        return offline;
+    }
+
+    const finalLoadingText =
+        typeof loadingText === 'string'
+            ? translate(loadingText, {
+                  _: loadingText,
+              })
+            : loadingText;
     return (
         <>
             <StyledAutocomplete
@@ -634,12 +651,10 @@ If you provided a React element for the optionText prop, you must also provide t
                 closeText={translate(closeText, { _: closeText })}
                 loadingText={
                     isPaused && isPlaceholderData
-                        ? offline
-                        : typeof loadingText === 'string'
-                          ? translate(loadingText, {
-                                _: loadingText,
-                            })
-                          : loadingText
+                        ? offline !== false && offline !== undefined
+                            ? offline
+                            : finalLoadingText
+                        : finalLoadingText
                 }
                 openOnFocus
                 openText={translate(openText, { _: openText })}

packages/ra-ui-materialui/src/input/ReferenceInput.tsx

@@ -2,7 +2,6 @@ import React from 'react';
 import { ReferenceInputBase, ReferenceInputBaseProps } from 'ra-core';
 
 import { AutocompleteInput } from './AutocompleteInput';
-import { Offline } from '../Offline';
 
 /**
  * An Input component for choosing a reference record. Useful for foreign keys.
@@ -65,27 +64,18 @@ import { Offline } from '../Offline';
  * a `setFilters` function. You can call this function to filter the results.
  */
 export const ReferenceInput = (props: ReferenceInputProps) => {
-    const {
-        children = defaultChildren,
-        offline = defaultOffline,
-        ...rest
-    } = props;
+    const { children = defaultChildren, ...rest } = props;
 
     if (props.validate && process.env.NODE_ENV !== 'production') {
         throw new Error(
             '<ReferenceInput> does not accept a validate prop. Set the validate prop on the child instead.'
         );
     }
 
-    return (
-        <ReferenceInputBase {...rest} offline={offline}>
-            {children}
-        </ReferenceInputBase>
-    );
+    return <ReferenceInputBase {...rest}>{children}</ReferenceInputBase>;
 };
 
 const defaultChildren = <AutocompleteInput />;
-const defaultOffline = <Offline variant="inline" />;
 
 export interface ReferenceInputProps extends ReferenceInputBaseProps {
     /**