Skip to content

Commit d38453a

Browse files
committed
Apply review suggestions
1 parent 45d824e commit d38453a

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

packages/ra-core/src/controller/field/useReferenceManyFieldController.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export const useReferenceManyFieldController = <
6464
sort: initialSort = { field: 'id', order: 'DESC' },
6565
queryOptions = {} as UseQueryOptions<
6666
{ data: ReferenceRecordType[]; total: number },
67-
Error
67+
ErrorType
6868
>,
6969
} = props;
7070
const notify = useNotify();
@@ -182,7 +182,6 @@ export const useReferenceManyFieldController = <
182182
},
183183
{
184184
enabled: get(record, source) != null,
185-
// @ts-expect-error FIXME The error type is not correctly inferred
186185
placeholderData: previousData => previousData,
187186
onError: error =>
188187
notify(

packages/ra-core/src/controller/list/ListController.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { ReactNode } from 'react';
12
import { RaRecord } from '../../types';
23
import {
34
useListController,
@@ -27,7 +28,7 @@ export const ListController = <
2728
}: {
2829
children: (
2930
params: ListControllerResult<RecordType, ErrorType>
30-
) => JSX.Element;
31+
) => ReactNode;
3132
} & ListControllerProps<RecordType, ErrorType>) => {
3233
const controllerProps = useListController<RecordType, ErrorType>(props);
3334
return children(controllerProps);

packages/ra-core/src/controller/show/ShowController.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { ReactNode } from 'react';
12
import { RaRecord } from '../../types';
23
import {
34
useShowController,
@@ -27,7 +28,7 @@ export const ShowController = <
2728
}: {
2829
children: (
2930
params: ShowControllerResult<RecordType, ErrorType>
30-
) => JSX.Element;
31+
) => ReactNode;
3132
} & ShowControllerProps<RecordType, ErrorType>) => {
3233
const controllerProps = useShowController<RecordType, ErrorType>(props);
3334
return children(controllerProps);

packages/ra-ui-materialui/src/field/ReferenceField.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ export const ReferenceFieldView = <
115115
aria-errormessage={
116116
typeof error === 'string' ? error : error?.message
117117
}
118-
role="presentation"
119118
color="error"
120119
fontSize="small"
121120
/>

0 commit comments

Comments
 (0)