codemod -> if exist display label instead of source

Author: erwanMarmelab

packages/ra-core/codemods/__testfixtures__/replace-Datagrid-DataTable-ManyChildren.input.tsx

@@ -20,6 +20,10 @@ const PostList = () => (
         <Datagrid>
             <TextField source="id" />
             <EmailField source="email" />
+            <EmailField
+                source="author_email"
+                label="Email of the author of the post"
+            />
             <NumberField source="nb_vues" />
             <NumberField
                 source="price"

packages/ra-core/codemods/__testfixtures__/replace-Datagrid-DataTable-ManyChildren.output.tsx

@@ -21,13 +21,18 @@ const PostList = () => (
             <DataTable.Col source="email">
                 <EmailField source="email" />
             </DataTable.Col>
+            <DataTable.Col label="Email of the author of the post">
+                <EmailField
+                    source="author_email"
+                    label="Email of the author of the post"
+                />
+            </DataTable.Col>
             <DataTable.NumberCol source="nb_vues" />
             <DataTable.NumberCol
                 source="price"
                 locales="fr-FR"
                 options={{ style: 'currency', currency: 'USD' }}
             />
-
             <DataTable.Col source="title" />
             <DataTable.Col source="userId">
                 <ReferenceField source="userId" reference="users">

packages/ra-core/codemods/replace-Datagrid-DataTable.ts

@@ -14,7 +14,7 @@ module.exports = (file, api: j.API) => {
         return root.toSource();
     }
 
-    wrapChildren(root, j);
+    transformChildren(root, j);
     cleanImports(root, j);
 
     return root.toSource({ quote: 'single', lineTerminator: '\n' });
@@ -139,7 +139,7 @@ const cleanAttributes = (node, j) => {
     return sxRenamedAttributes;
 };
 
-const wrapChildren = (root, j) => {
+const transformChildren = (root, j) => {
     // Find all instances of Datagrid
     const datagridComponents = root.find(j.JSXElement, {
         openingElement: {
@@ -176,7 +176,7 @@ const transformChild = (root, j, child) => {
                 !['source', 'label', 'empty'].includes(attr.name.name)
         )
     ) {
-        newChild = replaceTextField(j, child);
+        child.openingElement.name.name = 'DataTable.Col';
     } else if (
         j.JSXElement.check(child) &&
         child.openingElement.name.type === 'JSXIdentifier' &&
@@ -189,28 +189,31 @@ const transformChild = (root, j, child) => {
                 )
         )
     ) {
-        newChild = replaceNumberField(j, child);
+        child.openingElement.name.name = 'DataTable.NumberCol';
     } else {
         newChild = wrapChild(j, child);
-    }
 
-    // Replace the original child with the new child
-    root.find(j.JSXElement, {
-        openingElement: {
-            name: {
-                type: 'JSXIdentifier',
-                name: 'DataTable',
+        // Replace the original child with the new child
+        root.find(j.JSXElement, {
+            openingElement: {
+                name: {
+                    type: 'JSXIdentifier',
+                    name: 'DataTable',
+                },
             },
-        },
-    }).forEach(dataTableComponent => {
-        dataTableComponent.value.children =
-            dataTableComponent.value.children.map(c =>
-                c === child ? newChild : c
-            );
-    });
+        }).forEach(dataTableComponent => {
+            dataTableComponent.value.children =
+                dataTableComponent.value.children.map(c =>
+                    c === child ? newChild : c
+                );
+        });
+    }
 };
 
 const wrapChild = (j, child) => {
+    const labelAttribute = child.openingElement.attributes.find(
+        attr => j.JSXAttribute.check(attr) && attr.name.name === 'label'
+    );
     const sourceAttribute = child.openingElement.attributes.find(
         attr => j.JSXAttribute.check(attr) && attr.name.name === 'source'
     );
@@ -219,34 +222,18 @@ const wrapChild = (j, child) => {
     return j.jsxElement(
         j.jsxOpeningElement(
             j.jsxIdentifier('DataTable.Col'),
-            !sourceAttribute ? [] : [sourceAttribute],
+            labelAttribute
+                ? [labelAttribute]
+                : sourceAttribute
+                  ? [sourceAttribute]
+                  : [],
             false
         ),
         j.jsxClosingElement(j.jsxIdentifier('DataTable.Col')),
         [j.jsxText('\n'), child, j.jsxText('\n')]
     );
 };
 
-const replaceTextField = (j, child) => {
-    return j.jsxElement(
-        j.jsxOpeningElement(
-            j.jsxIdentifier('DataTable.Col'),
-            child.openingElement.attributes,
-            true
-        )
-    );
-};
-
-const replaceNumberField = (j, child) => {
-    return j.jsxElement(
-        j.jsxOpeningElement(
-            j.jsxIdentifier('DataTable.NumberCol'),
-            child.openingElement.attributes,
-            true
-        )
-    );
-};
-
 const cleanImports = (root, j) => {
     // Check if there is still a use of TextField in the code
     const textFieldUsage = root.find(j.JSXElement, {