Skip to content

Commit eeb1502

Browse files
djhislax57
andauthored
Apply suggestions from code review
Co-authored-by: Jean-Baptiste Kaiser <[email protected]>
1 parent eb48bad commit eeb1502

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

docs/Menu.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,8 @@ export const MyMenu = () => (
187187
| -------------------------------- | -------- | -------------------- | -------------------- | ---------------------------------------- |
188188
| `to` | Required | `string | location` | - | The menu item's target. It is passed to a React Router [NavLink](https://reacttraining.com/react-router/web/api/NavLink) component. |
189189
| `primaryText` | Required | `ReactNode` | - | The menu content, displayed when the menu isn't minimized. |
190-
| `keyboardShortcut` | Optional | `string | string[]` | - | The keyboard shortcut(s) to activate this menu item |
191-
| `keyboardShortcutRepresentation` | Optional | `ReactNode` | `<keyboardShortcut>` | A react node that displays the keyboard shortcut |
190+
| `keyboardShortcut` | Optional | `string` | - | The keyboard shortcut(s) to activate this menu item |
191+
| `keyboardShortcut Representation` | Optional | `ReactNode` | `<KeyboardShortcut>` | A react node that displays the keyboard shortcut |
192192
| `leftIcon` | Optional | `ReactNode` | - | The menu icon |
193193
| `sx` | Optional | `SxProp` | - | Style overrides, powered by MUI System |
194194

@@ -241,7 +241,7 @@ export const MyMenu = () => (
241241
<Menu.Item
242242
to="/sales"
243243
primaryText="Sales"
244-
// Letter G then letter S
244+
// G key then S key
245245
keyboardShortcut="G>S"
246246
/>
247247
</Menu>

packages/ra-ui-materialui/src/KeyboardShortcut.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,6 @@ export const KeyboardShortcut = ({
3636
? KeyMap[key]
3737
: key.toUpperCase()}
3838
</Typography>
39-
{keyIndex < keys.length - 1 ? (
40-
<>&nbsp;</>
41-
) : null}
4239
</React.Fragment>
4340
))}
4441
{sequenceIndex < sequences.length - 1 ? (

0 commit comments

Comments
 (0)