Skip to content

Commit 10260a4

Browse files
committed
osbuild: use new host_as_buildroot var when configuring the buildroot
This makes it a little more explicit.
1 parent fdadc1f commit 10260a4

File tree

4 files changed

+40
-36
lines changed

4 files changed

+40
-36
lines changed

src/osbuild-manifests/coreos.osbuild.aarch64.mpp.yaml

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,6 @@ mpp-vars:
2525
boot_fs_label: boot
2626
root_fs_uuid: 910678ff-f77e-4a7d-8d53-86f2ac47a823
2727
root_fs_label: root
28-
# Set the buildroot string to use for most operations here. We create
29-
# the buildroot from the target OSTree contents so we have version
30-
# matches. Unfortunately for FCOS there is no python so we can't
31-
# really use FCOS as the buildroot so we'll set it to "" so that
32-
# the host (COSA) gets used as the buildroot there.
33-
buildroot:
34-
mpp-if: osname in ['rhcos', 'scos']
35-
then: "name:deployed-tree"
36-
else: ""
3728
# For some stages (i.e. the qemu stages) we'll use the host as
3829
# the buildroot (i.e. COSA in most cases but sometimes just
3930
# the actual HOST filesystem like in coreos/custom-coreos-disk-images).
@@ -43,6 +34,16 @@ mpp-vars:
4334
# the host buildroot is the default if nothing is specified.
4435
# We're still defining it here in an attempt to be explicit.
4536
host_as_buildroot: ""
37+
# Set the buildroot string to use for most operations here. We create
38+
# the buildroot from the target OSTree contents so we have version
39+
# matches. Unfortunately for FCOS there is no python so we can't
40+
# really use FCOS as the buildroot so we'll use the host as the
41+
# buildroot there.
42+
buildroot:
43+
mpp-if: osname in ['rhcos', 'scos']
44+
then: "name:deployed-tree"
45+
else:
46+
mpp-format-string: '{host_as_buildroot}'
4647
mpp-define-images:
4748
- id: image
4849
sector_size:

src/osbuild-manifests/coreos.osbuild.ppc64le.mpp.yaml

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,6 @@ mpp-vars:
2525
boot_fs_label: boot
2626
root_fs_uuid: 910678ff-f77e-4a7d-8d53-86f2ac47a823
2727
root_fs_label: root
28-
# Set the buildroot string to use for most operations here. We create
29-
# the buildroot from the target OSTree contents so we have version
30-
# matches. Unfortunately for FCOS there is no python so we can't
31-
# really use FCOS as the buildroot so we'll set it to "" so that
32-
# the host (COSA) gets used as the buildroot there.
33-
buildroot:
34-
mpp-if: osname in ['rhcos', 'scos']
35-
then: "name:deployed-tree"
36-
else: ""
3728
# For some stages (i.e. the qemu stages) we'll use the host as
3829
# the buildroot (i.e. COSA in most cases but sometimes just
3930
# the actual HOST filesystem like in coreos/custom-coreos-disk-images).
@@ -43,6 +34,16 @@ mpp-vars:
4334
# the host buildroot is the default if nothing is specified.
4435
# We're still defining it here in an attempt to be explicit.
4536
host_as_buildroot: ""
37+
# Set the buildroot string to use for most operations here. We create
38+
# the buildroot from the target OSTree contents so we have version
39+
# matches. Unfortunately for FCOS there is no python so we can't
40+
# really use FCOS as the buildroot so we'll use the host as the
41+
# buildroot there.
42+
buildroot:
43+
mpp-if: osname in ['rhcos', 'scos']
44+
then: "name:deployed-tree"
45+
else:
46+
mpp-format-string: '{host_as_buildroot}'
4647
mpp-define-images:
4748
- id: image
4849
sector_size:

src/osbuild-manifests/coreos.osbuild.s390x.mpp.yaml

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,6 @@ mpp-vars:
2929
boot_fs_label: boot
3030
root_fs_uuid: 910678ff-f77e-4a7d-8d53-86f2ac47a823
3131
root_fs_label: root
32-
# Set the buildroot string to use for most operations here. We create
33-
# the buildroot from the target OSTree contents so we have version
34-
# matches. Unfortunately for FCOS there is no python so we can't
35-
# really use FCOS as the buildroot so we'll set it to "" so that
36-
# the host (COSA) gets used as the buildroot there.
37-
buildroot:
38-
mpp-if: osname in ['rhcos', 'scos']
39-
then: "name:deployed-tree"
40-
else: ""
4132
# For some stages (i.e. the qemu stages) we'll use the host as
4233
# the buildroot (i.e. COSA in most cases but sometimes just
4334
# the actual HOST filesystem like in coreos/custom-coreos-disk-images).
@@ -47,6 +38,16 @@ mpp-vars:
4738
# the host buildroot is the default if nothing is specified.
4839
# We're still defining it here in an attempt to be explicit.
4940
host_as_buildroot: ""
41+
# Set the buildroot string to use for most operations here. We create
42+
# the buildroot from the target OSTree contents so we have version
43+
# matches. Unfortunately for FCOS there is no python so we can't
44+
# really use FCOS as the buildroot so we'll use the host as the
45+
# buildroot there.
46+
buildroot:
47+
mpp-if: osname in ['rhcos', 'scos']
48+
then: "name:deployed-tree"
49+
else:
50+
mpp-format-string: '{host_as_buildroot}'
5051
mpp-define-images:
5152
- id: image
5253
sector_size:

src/osbuild-manifests/coreos.osbuild.x86_64.mpp.yaml

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,6 @@ mpp-vars:
2525
boot_fs_label: boot
2626
root_fs_uuid: 910678ff-f77e-4a7d-8d53-86f2ac47a823
2727
root_fs_label: root
28-
# Set the buildroot string to use for most operations here. We create
29-
# the buildroot from the target OSTree contents so we have version
30-
# matches. Unfortunately for FCOS there is no python so we can't
31-
# really use FCOS as the buildroot so we'll set it to "" so that
32-
# the host (COSA) gets used as the buildroot there.
33-
buildroot:
34-
mpp-if: osname in ['rhcos', 'scos']
35-
then: "name:deployed-tree"
36-
else: ""
3728
# For some stages (i.e. the qemu stages) we'll use the host as
3829
# the buildroot (i.e. COSA in most cases but sometimes just
3930
# the actual HOST filesystem like in coreos/custom-coreos-disk-images).
@@ -43,6 +34,16 @@ mpp-vars:
4334
# the host buildroot is the default if nothing is specified.
4435
# We're still defining it here in an attempt to be explicit.
4536
host_as_buildroot: ""
37+
# Set the buildroot string to use for most operations here. We create
38+
# the buildroot from the target OSTree contents so we have version
39+
# matches. Unfortunately for FCOS there is no python so we can't
40+
# really use FCOS as the buildroot so we'll use the host as the
41+
# buildroot there.
42+
buildroot:
43+
mpp-if: osname in ['rhcos', 'scos']
44+
then: "name:deployed-tree"
45+
else:
46+
mpp-format-string: '{host_as_buildroot}'
4647
mpp-define-images:
4748
- id: image
4849
sector_size:

0 commit comments

Comments
 (0)